Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 546643002: android: Enable media autoplay for webview test shell (Closed)

Created:
6 years, 3 months ago by no sievers
Modified:
6 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clankium
Project:
chromium
Visibility:
Public.

Description

android: Enable media autoplay for webview test shell This is required for WebGL conformance tests and cannot be passed on the cmdline the way WebView overrides this from AwSettings. Committed: https://crrev.com/ce87a386deb23871aafe5c4c2cc96e63e3d65615 Cr-Commit-Position: refs/heads/master@{#293429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
no sievers
ptal
6 years, 3 months ago (2014-09-05 00:09:32 UTC) #2
no sievers
On 2014/09/05 00:09:32, sievers wrote: > ptal yea content shell overrides this too: https://code.google.com/p/chromium/codesearch#chromium/src/content/shell/app/shell_main_delegate.cc&q=formediaplayback&sq=package:chromium&type=cs&l=152
6 years, 3 months ago (2014-09-05 00:19:00 UTC) #3
boliu
lgtm Serves as a reminder that I should enable testMediaPlaybackWithUserGesture when I get a chance..
6 years, 3 months ago (2014-09-05 00:20:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/546643002/1
6 years, 3 months ago (2014-09-05 00:24:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as a49b4130db5a5607400394dc2aabf29ae28fa923
6 years, 3 months ago (2014-09-05 03:58:31 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce87a386deb23871aafe5c4c2cc96e63e3d65615
Cr-Commit-Position: refs/heads/master@{#293429}

Powered by Google App Engine
This is Rietveld 408576698