Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
546633006:
[DevTools] Check m_frontendPage in InspectorFrontendHost. (Closed)
|
Created:
6 years, 3 months ago by dgozman Modified:
6 years, 3 months ago CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org Base URL:
svn://svn.chromium.org/blink/trunk Project:
blink Visibility:
Public. |
Description[DevTools] Check m_frontendPage in InspectorFrontendHost.
This is another speculative crash fix (previous one was r181045).
BUG=400483
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181509
Patch Set 1 #
Total comments: 3
Messages
Total messages: 21 (10 generated)
dgozman@chromium.org changed reviewers: + pfeldman@chromium.org, vsevik@chromium.org
Please take a look.
https://codereview.chromium.org/546633006/diff/1/Source/core/inspector/Inspec... File Source/core/inspector/InspectorFrontendHost.cpp (right): https://codereview.chromium.org/546633006/diff/1/Source/core/inspector/Inspec... Source/core/inspector/InspectorFrontendHost.cpp:149: if (!m_frontendPage) Why does this get called after disconnectClient?
https://codereview.chromium.org/546633006/diff/1/Source/core/inspector/Inspec... File Source/core/inspector/InspectorFrontendHost.cpp (right): https://codereview.chromium.org/546633006/diff/1/Source/core/inspector/Inspec... Source/core/inspector/InspectorFrontendHost.cpp:149: if (!m_frontendPage) On 2014/09/06 10:30:29, pfeldman wrote: > Why does this get called after disconnectClient? That's a reasonable question. The answer is: I don't know. I cannot repro the crash, so I'm trying to fix it experimentally. If you have any idea, please tell.
https://codereview.chromium.org/546633006/diff/1/Source/core/inspector/Inspec... File Source/core/inspector/InspectorFrontendHost.cpp (right): https://codereview.chromium.org/546633006/diff/1/Source/core/inspector/Inspec... Source/core/inspector/InspectorFrontendHost.cpp:149: if (!m_frontendPage) On 2014/09/06 10:30:29, pfeldman wrote: > Why does this get called after disconnectClient? That's a reasonable question. The answer is: I don't know. I cannot repro the crash, so I'm trying to fix it experimentally. If you have any idea, please tell.
https://codereview.chromium.org/546633006/diff/1/Source/core/inspector/Inspec... File Source/core/inspector/InspectorFrontendHost.cpp (right): https://codereview.chromium.org/546633006/diff/1/Source/core/inspector/Inspec... Source/core/inspector/InspectorFrontendHost.cpp:149: if (!m_frontendPage) Could this be due to microtasks that are dispatching protocol messages? disconnectClient is called from within willBeDestroyed, so theoretically things could happen after it. lgtm
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/546633006/1
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded time limit waiting for builds to trigger.
The CQ bit was checked by dgozman@chromium.org
The CQ bit was unchecked by dgozman@chromium.org
The CQ bit was checked by dgozman@chromium.org
The CQ bit was unchecked by dgozman@chromium.org
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/546633006/1
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded time limit waiting for builds to trigger.
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/546633006/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181509 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
