Refactoring the code for location manager.

content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.content.Context;
 import android.location.Criteria;
 import android.location.Location;
 import android.location.LocationListener;
@@ skipping 132 matching lines @@
             ensureLocationManagerCreated();
             if (usePassiveOneShotLocation()) return;
 
             assert !mIsRunning;
             mIsRunning = true;
 
             // We're running on the main thread. The C++ side is responsible to
             // bounce notifications to the Geolocation thread as they arrive in the mainLooper.
             try {
                 Criteria criteria = new Criteria();
+                if (isGpsEnabled)
+                    criteria.setAccuracy(Criteria.ACCURACY_FINE);

[jdduke (slow), 2014/09/07 13:19:26]

The if body should be on the same line as the if condition (assuming the width
is less than 100 characters).

                 mLocationManager.requestLocationUpdates(0, 0, criteria, this,
                         ThreadUtils.getUiThreadLooper());
-                if (isGpsEnabled) {
-                    criteria.setAccuracy(Criteria.ACCURACY_FINE);
-                    mLocationManager.requestLocationUpdates(0, 0, criteria, this,
-                            ThreadUtils.getUiThreadLooper());
-                }
             } catch (SecurityException e) {
                 Log.e(TAG, "Caught security exception registering for location updates from " +
                     "system. This should only happen in DumpRenderTree.");
             } catch (IllegalArgumentException e) {
                 Log.e(TAG, "Caught IllegalArgumentException registering for location updates.");
             }
         }
 
         /**
          * Unregisters this object from the location service.
@@ skipping 30 matching lines @@
          */
         private boolean isOnlyPassiveLocationProviderEnabled() {
             List<String> providers = mLocationManager.getProviders(true);
             return providers != null && providers.size() == 1
                     && providers.get(0).equals(LocationManager.PASSIVE_PROVIDER);
         }
     }
 }