Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/browser/extensions/extension_protocols_unittest.cc

Issue 546633003: Move ExtensionProtocolsTest back to src/chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (extension-protocols) typo Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/url_request_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_protocols_unittest.cc
diff --git a/extensions/browser/extension_protocols_unittest.cc b/chrome/browser/extensions/extension_protocols_unittest.cc
similarity index 98%
rename from extensions/browser/extension_protocols_unittest.cc
rename to chrome/browser/extensions/extension_protocols_unittest.cc
index e9aea853e65f33111e2e4c48348d19093c621b70..3bf6328d74d7230a7bead90dbe4a5eb126d017c4 100644
--- a/extensions/browser/extension_protocols_unittest.cc
+++ b/chrome/browser/extensions/extension_protocols_unittest.cc
@@ -11,7 +11,6 @@
#include "base/strings/string_util.h"
#include "base/values.h"
#include "chrome/common/chrome_paths.h"
-//#include "chrome/common/url_constants.h"
#include "content/public/browser/resource_request_info.h"
#include "content/public/test/mock_resource_context.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -29,6 +28,7 @@
using content::ResourceType;
namespace extensions {
+namespace {
scoped_refptr<Extension> CreateTestExtension(const std::string& name,
bool incognito_split_mode) {
@@ -89,6 +89,11 @@ scoped_refptr<Extension> CreateTestResponseHeaderExtension() {
return extension;
}
+} // namespace
+
+// This test lives in src/chrome instead of src/extensions because it tests
+// functionality delegated back to Chrome via ChromeExtensionsBrowserClient.
+// See chrome/browser/extensions/url_request_util.cc.
class ExtensionProtocolTest : public testing::Test {
public:
ExtensionProtocolTest()
« no previous file with comments | « no previous file | chrome/browser/extensions/url_request_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698