Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 546633003: Move ExtensionProtocolsTest back to src/chrome (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ExtensionProtocolsTest back to src/chrome It lives in src/extensions now, but has src/chrome dependencies and tests code implemented in src/chrome. Attempting to refactor it to split out the src/chrome dependencies just made a mess of the code. Since it tests Chrome concepts, put it there. BUG=397164 TEST=unit_tests Committed: https://crrev.com/8816ae54afab2da619a7ee23a50b90869b4b2a90 Cr-Commit-Position: refs/heads/master@{#293541}

Patch Set 1 #

Patch Set 2 : (extension-protocols) typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -362 lines) Patch
A + chrome/browser/extensions/extension_protocols_unittest.cc View 1 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/url_request_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download
D extensions/browser/extension_protocols_unittest.cc View 1 chunk +0 lines, -359 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
yoz, PTAL
6 years, 3 months ago (2014-09-05 00:23:03 UTC) #2
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-05 00:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/546633003/20001
6 years, 3 months ago (2014-09-05 16:02:48 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5cde19c5f3dda1e2581215075742e705620f94ae
6 years, 3 months ago (2014-09-05 17:03:29 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:14 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8816ae54afab2da619a7ee23a50b90869b4b2a90
Cr-Commit-Position: refs/heads/master@{#293541}

Powered by Google App Engine
This is Rietveld 408576698