Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 546633002: Roll gyp r1972:1973 (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll gyp r1972:1973 r1973: Changes the ninja generator to output phony targets for uninteresting targets BUG=410410 TEST=none R=thakis@chromium.org Committed: https://crrev.com/f0728a37c866c9b1a9a31a0938df034af5f7714c Cr-Commit-Position: refs/heads/master@{#293423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
6 years, 3 months ago (2014-09-05 00:04:05 UTC) #1
Nico
rs-lgtm
6 years, 3 months ago (2014-09-05 00:06:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/546633002/1
6 years, 3 months ago (2014-09-05 00:09:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 82f612b91e7d16880b26922f8b0b2cdc1490141b
6 years, 3 months ago (2014-09-05 03:39:27 UTC) #5
jochen (gone - plz use gerrit)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/547303002/ by jochen@chromium.org. ...
6 years, 3 months ago (2014-09-08 08:05:40 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0728a37c866c9b1a9a31a0938df034af5f7714c
Cr-Commit-Position: refs/heads/master@{#293423}

Powered by Google App Engine
This is Rietveld 408576698