tests/corelib/int_from_environment_default_value_test.dart - Issue 54663002: Change int.fromEnvironment in VM to use same code as int.parse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/corelib/int_from_environment_default_value_test.dart

Issue 54663002: Change int.fromEnvironment in VM to use same code as int.parse. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Change order for String/bool too. Add canonicalization. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/corelib/int_from_environment_default_value_test.dart

diff --git a/tests/corelib/int_from_environment_default_value_test.dart b/tests/corelib/int_from_environment_default_value_test.dart

index bb318d00c5a31440ba3be6f05c59bb81f07f31f7..d97145a6e6eef689e574a56abe910c4536d33313 100644

--- a/tests/corelib/int_from_environment_default_value_test.dart

+++ b/tests/corelib/int_from_environment_default_value_test.dart

@@ -6,5 +6,6 @@ import "package:expect/expect.dart";

main() {

Expect.isNull(const int.fromEnvironment('NOT_FOUND'));

- Expect.equals(12345, const int.fromEnvironment('NOT_FOUND', defaultValue: 12345));

+ Expect.equals(12345, const int.fromEnvironment('NOT_FOUND',

+ defaultValue: 12345));

}

« runtime/lib/integers.cc ('K') | « tests/corelib/int_from_environment2_test.dart ('k') | tests/corelib/int_from_environment_test.dart » ('j') | no next file with comments »