Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: runtime/lib/bool.cc

Issue 54663002: Change int.fromEnvironment in VM to use same code as int.parse. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Change order for String/bool too. Add canonicalization. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/lib/integers.cc » ('j') | runtime/lib/integers.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/bootstrap_natives.h" 5 #include "vm/bootstrap_natives.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "vm/bigint_operations.h" 8 #include "vm/bigint_operations.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/dart_api_impl.h" 10 #include "vm/dart_api_impl.h"
11 #include "vm/exceptions.h" 11 #include "vm/exceptions.h"
12 #include "vm/isolate.h" 12 #include "vm/isolate.h"
13 #include "vm/native_entry.h" 13 #include "vm/native_entry.h"
14 #include "vm/object.h" 14 #include "vm/object.h"
15 #include "vm/object_store.h" 15 #include "vm/object_store.h"
16 #include "vm/symbols.h" 16 #include "vm/symbols.h"
17 17
18 namespace dart { 18 namespace dart {
19 19
20 DEFINE_NATIVE_ENTRY(Bool_fromEnvironment, 3) { 20 DEFINE_NATIVE_ENTRY(Bool_fromEnvironment, 3) {
21 GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(1)); 21 GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(1));
22 GET_NATIVE_ARGUMENT(Bool, default_value, arguments->NativeArgAt(2)); 22 GET_NATIVE_ARGUMENT(Bool, default_value, arguments->NativeArgAt(2));
23 // Call the embedder to supply us with the environment. 23 // Call the embedder to supply us with the environment.
24 Dart_EnvironmentCallback callback = isolate->environment_callback(); 24 Dart_EnvironmentCallback callback = isolate->environment_callback();
25 if (callback != NULL) { 25 if (callback != NULL) {
26 Dart_Handle result = callback(Api::NewHandle(isolate, name.raw())); 26 Dart_Handle result = callback(Api::NewHandle(isolate, name.raw()));
27 if (Dart_IsError(result)) { 27 if (Dart_IsString(result)) {
28 const char *chars;
29 Dart_StringToCString(result, &chars);
30 return (strcmp("true", chars) == 0)
31 ? Bool::True().raw() : Bool::False().raw();
32 } else if (Dart_IsError(result)) {
28 const Object& error = 33 const Object& error =
29 Object::Handle(isolate, Api::UnwrapHandle(result)); 34 Object::Handle(isolate, Api::UnwrapHandle(result));
30 Exceptions::ThrowArgumentError( 35 Exceptions::ThrowArgumentError(
31 String::Handle( 36 String::Handle(
32 String::New(Error::Cast(error).ToErrorCString()))); 37 String::New(Error::Cast(error).ToErrorCString())));
33 } else if (Dart_IsString(result)) {
34 const char *chars;
35 Dart_StringToCString(result, &chars);
36 return (strcmp("true", chars) == 0)
37 ? Bool::True().raw() : Bool::False().raw();
38 } else if (!Dart_IsNull(result)) { 38 } else if (!Dart_IsNull(result)) {
39 Exceptions::ThrowArgumentError( 39 Exceptions::ThrowArgumentError(
40 String::Handle(String::New("Illegal environment value"))); 40 String::Handle(String::New("Illegal environment value")));
41 } 41 }
42 } 42 }
43 return default_value.raw(); 43 return default_value.raw();
44 } 44 }
45 45
46 } // namespace dart 46 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/lib/integers.cc » ('j') | runtime/lib/integers.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698