Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 546573003: WebUI: Change checkbox vertical offset for Chromeos. (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

WebUI: Change checkbox vertical offset for Chromeos. BUG=411083 Committed: https://crrev.com/9c2250be5832ea7ea37a9c51af23a5d8db922565 Cr-Commit-Position: refs/heads/master@{#293432}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/webui/resources/css/widgets.css View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
Evan Stade
6 years, 3 months ago (2014-09-04 23:42:45 UTC) #2
Dan Beam
lgtm
6 years, 3 months ago (2014-09-04 23:49:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/546573003/1
6 years, 3 months ago (2014-09-04 23:58:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0effca0b2cc1e55ed3b12ea6a92a73a30698421c
6 years, 3 months ago (2014-09-05 04:15:07 UTC) #6
stevenjb
On 2014/09/05 04:15:07, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 3 months ago (2014-09-05 16:32:05 UTC) #7
Dan Beam
https://codereview.chromium.org/546573003/diff/1/ui/webui/resources/css/widgets.css File ui/webui/resources/css/widgets.css (right): https://codereview.chromium.org/546573003/diff/1/ui/webui/resources/css/widgets.css#newcode71 ui/webui/resources/css/widgets.css:71: < expr="not chromeos"> you're missing an if here... sorry, ...
6 years, 3 months ago (2014-09-05 17:42:33 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c2250be5832ea7ea37a9c51af23a5d8db922565
Cr-Commit-Position: refs/heads/master@{#293432}

Powered by Google App Engine
This is Rietveld 408576698