Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4539)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 546523002: Improve error messaging with shared module import failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index c02602f7a0bf026ddf6835bf3d9fa5215be00639..8a370a03f3bee350911abfcbe7003d3f0afab23f 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -494,10 +494,10 @@ void CrxInstaller::CheckInstall() {
} else if (imported_module &&
!SharedModuleInfo::IsExportAllowedByWhitelist(imported_module,
extension()->id())) {
- ReportFailureFromUIThread(
- CrxInstallerError(l10n_util::GetStringFUTF16(
- IDS_EXTENSION_INSTALL_DEPENDENCY_NOT_WHITELISTED,
- base::ASCIIToUTF16(i->extension_id))));
+ ReportFailureFromUIThread(CrxInstallerError(l10n_util::GetStringFUTF16(
+ IDS_EXTENSION_INSTALL_DEPENDENCY_NOT_WHITELISTED,
+ base::UTF8ToUTF16(extension()->name()),
+ base::UTF8ToUTF16(imported_module->name()))));
return;
}
}
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698