Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 546513002: Remove redundant invalidation in RenderLayerModelObject::styleDidChange() (Closed)

Created:
6 years, 3 months ago by Xianzhu
Modified:
6 years, 3 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove redundant invalidation in RenderLayerModelObject::styleDidChange() RenderStyle::visualInvalidationDiff() is already returning 'more than enough' paint invalidation flag. The setShouldDoFullPaintInvalidation() call in RenderLayerModelObject::styleDidChange() is just redundant. BUG=349061 TEST=all existing tests pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/core/rendering/RenderLayerModelObject.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Xianzhu
6 years, 3 months ago (2014-09-05 16:47:51 UTC) #2
dsinclair
lgtm
6 years, 3 months ago (2014-09-05 16:50:58 UTC) #3
Julien - ping for review
lgtm
6 years, 3 months ago (2014-09-05 17:12:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/546513002/1
6 years, 3 months ago (2014-09-05 17:13:51 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-05 19:14:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/546513002/1
6 years, 3 months ago (2014-09-05 19:24:10 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 20:17:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181480

Powered by Google App Engine
This is Rietveld 408576698