Notify the Chrome browser process about the window being activated from the viewer process.

Notify the Chrome browser process about the window being activated from the viewer process.

This only applies to Chrome OS mode on Windows 7. In the corresponding handler on the browser side
we request the compositor to schedule a paint for the whole window.

BUG=409765
TBR=jschuh

Committed: https://crrev.com/5bae28efcda1eba2f4fcd6862926a4ba508dc63d
Cr-Commit-Position: refs/heads/master@{#293417}

[ananta, 2014-09-04 18:48:46]

ananta@chromium.org changed reviewers:
+ cpu@chromium.org

[ananta, 2014-09-04 18:48:55]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2014-09-04 18:49:18]

sky for ui\aura review.
cpu. For everything.

[sky, 2014-09-04 18:57:38]

https://codereview.chromium.org/546503002/diff/20001/ui/aura/remote_window_tr...
File ui/aura/remote_window_tree_host_win.cc (right):

https://codereview.chromium.org/546503002/diff/20001/ui/aura/remote_window_tr...
ui/aura/remote_window_tree_host_win.cc:382: if (compositor())
Why do we need a full redraw on activation?

[ananta, 2014-09-04 19:02:19]

https://codereview.chromium.org/546503002/diff/20001/ui/aura/remote_window_tr...
File ui/aura/remote_window_tree_host_win.cc (right):

https://codereview.chromium.org/546503002/diff/20001/ui/aura/remote_window_tr...
ui/aura/remote_window_tree_host_win.cc:382: if (compositor())
On 2014/09/04 18:57:37, sky wrote:
> Why do we need a full redraw on activation?

On Windows 7 the metro window can be minimized by clicking on the taskbar
button. When we restore it back the window does not paint. On Windows 8 this is
a non issue.

Alternatively we can send in a bool in the IPC which defaults to false. For Win7
we can pass that as true. This bool would indicate if the window needs to be
redrawn.

[cpu_(ooo_6.6-7.5), 2014-09-04 19:13:21]

https://codereview.chromium.org/546503002/diff/20001/win8/metro_driver/chrome...
File win8/metro_driver/chrome_app_view_ash.cc (right):

https://codereview.chromium.org/546503002/diff/20001/win8/metro_driver/chrome...
win8/metro_driver/chrome_app_view_ash.cc:1299: } else {
// On windows 7 we need to force a redraw after the window is restored.

https://codereview.chromium.org/546503002/diff/20001/win8/metro_driver/metro_...
File win8/metro_driver/metro_driver_win7.cc (right):

https://codereview.chromium.org/546503002/diff/20001/win8/metro_driver/metro_...
win8/metro_driver/metro_driver_win7.cc:1002: winapp::Core::IFrameworkView*
app_view_;
CoreWindowEmulation is refcounted, it could outlive app_view ? meaning that
app_view could be pointing to freed memory?

[ananta, 2014-09-04 19:27:07]

https://codereview.chromium.org/546503002/diff/20001/win8/metro_driver/chrome...
File win8/metro_driver/chrome_app_view_ash.cc (right):

https://codereview.chromium.org/546503002/diff/20001/win8/metro_driver/chrome...
win8/metro_driver/chrome_app_view_ash.cc:1299: } else {
On 2014/09/04 19:13:21, cpu wrote:
> // On windows 7 we need to force a redraw after the window is restored.

Added a comment. We also pass in a bool in the IPC to indicate that the
window needs to be repainted.

https://codereview.chromium.org/546503002/diff/20001/win8/metro_driver/metro_...
File win8/metro_driver/metro_driver_win7.cc (right):

https://codereview.chromium.org/546503002/diff/20001/win8/metro_driver/metro_...
win8/metro_driver/metro_driver_win7.cc:1002: winapp::Core::IFrameworkView*
app_view_;
On 2014/09/04 19:13:21, cpu wrote:
> CoreWindowEmulation is refcounted, it could outlive app_view ? meaning that
> app_view could be pointing to freed memory?

Made app_view a ComPtr.

[sky, 2014-09-04 21:23:51]

Thanks for the clarification. LGTM

[ananta, 2014-09-04 22:02:26]

ananta@chromium.org changed reviewers:
+ palmer@chromium.org

[ananta, 2014-09-04 22:02:53]

+palmer for metro_viewer_messages.h owners stamp

[cpu_(ooo_6.6-7.5), 2014-09-04 22:03:54]

lgtm

[palmer, 2014-09-04 22:12:16]

LGTM

[ananta, 2014-09-04 22:17:38]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-09-04 22:21:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/546503002/40001

[commit-bot: I haz the power, 2014-09-05 00:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 00:13:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ananta, 2014-09-05 00:16:09]

ananta@chromium.org changed reviewers:
+ jschuh@chromium.org

[ananta, 2014-09-05 00:23:02]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-09-05 00:24:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/546503002/40001

[commit-bot: I haz the power, 2014-09-05 03:17:50]

Committed patchset #3 (id:40001) as c190aedaddbfb796db067a9f00743e79f1159a9b

[commit-bot: I haz the power, 2014-09-10 03:36:09]

Patchset 3 (id:??) landed as
https://crrev.com/5bae28efcda1eba2f4fcd6862926a4ba508dc63d
Cr-Commit-Position: refs/heads/master@{#293417}