Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 546493002: remove getTotalClipAsPath, privatize getTotalClip (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove getTotalClipAsPath, privatize getTotalClip TBR=robertphilips Committed: https://skia.googlesource.com/skia/+/fa35f8e6ebc9d98d57d2edc35e4a83556eb75cae

Patch Set 1 #

Patch Set 2 : namespaces are awesome (not) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M include/core/SkCanvas.h View 1 4 chunks +12 lines, -5 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/546493002/1
6 years, 3 months ago (2014-09-04 18:36:25 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/4046) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/561)
6 years, 3 months ago (2014-09-04 18:39:25 UTC) #4
reed1
6 years, 3 months ago (2014-09-04 19:06:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/546493002/20001
6 years, 3 months ago (2014-09-04 19:06:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as fa35f8e6ebc9d98d57d2edc35e4a83556eb75cae
6 years, 3 months ago (2014-09-04 19:14:41 UTC) #9
robertphillips
6 years, 3 months ago (2014-09-04 19:54:54 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698