Linux: add basic unprivileged namespace support.

Linux: add basic unprivileged namespace support.

The Credentials class now has basic support for unprivileged namespaces.

BUG=312380
R=jorgelo@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233041

[jln (very slow on Chromium), 2013-11-04 21:55:15]

Jorge: please take a look!

Kees: feel free to take a look as well!

(more CLs to follow)

[Jorge Lucangeli Obes, 2013-11-05 00:44:51]

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
File sandbox/linux/services/credentials.cc (right):

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
sandbox/linux/services/credentials.cc:73: // respecitively. It's ok to pass NULL
as one or both of the ids.
respectively

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
sandbox/linux/services/credentials.cc:174: DVLOG(1) << "Uids or Gids differ!";
uids/gids (you were not using caps above).

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
File sandbox/linux/services/credentials.h (right):

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
sandbox/linux/services/credentials.h:55: // To be secure, it's very important
that this API is not called with any
.. very important for this API not to be called...

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
sandbox/linux/services/credentials.h:56: // directory file descriptor present.
TODO(jln): integrate with
descriptors.

[jln (very slow on Chromium), 2013-11-05 00:54:42]

Thanks, PTAL!

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
File sandbox/linux/services/credentials.cc (right):

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
sandbox/linux/services/credentials.cc:73: // respecitively. It's ok to pass NULL
as one or both of the ids.
On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> respectively

Done.

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
sandbox/linux/services/credentials.cc:174: DVLOG(1) << "Uids or Gids differ!";
On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> uids/gids (you were not using caps above).

Done.

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
File sandbox/linux/services/credentials.h (right):

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
sandbox/linux/services/credentials.h:55: // To be secure, it's very important
that this API is not called with any
On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> .. very important for this API not to be called...

Done.

https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
sandbox/linux/services/credentials.h:56: // directory file descriptor present.
TODO(jln): integrate with
On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> descriptors.

palmer@ says that singular is "more common". Keeping unless you object.

[Jorge Lucangeli Obes, 2013-11-05 17:59:41]

On 2013/11/05 00:54:42, jln wrote:
> Thanks, PTAL!
> 
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> File sandbox/linux/services/credentials.cc (right):
> 
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> sandbox/linux/services/credentials.cc:73: // respecitively. It's ok to pass
NULL
> as one or both of the ids.
> On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> > respectively
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> sandbox/linux/services/credentials.cc:174: DVLOG(1) << "Uids or Gids differ!";
> On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> > uids/gids (you were not using caps above).
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> File sandbox/linux/services/credentials.h (right):
> 
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> sandbox/linux/services/credentials.h:55: // To be secure, it's very important
> that this API is not called with any
> On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> > .. very important for this API not to be called...
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> sandbox/linux/services/credentials.h:56: // directory file descriptor present.
> TODO(jln): integrate with
> On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> > descriptors.
> 
> palmer@ says that singular is "more common". Keeping unless you object.

lgtm

[Jorge Lucangeli Obes, 2013-11-05 18:00:17]

On 2013/11/05 17:59:41, Jorge Lucangeli Obes wrote:
> On 2013/11/05 00:54:42, jln wrote:
> > Thanks, PTAL!
> > 
> >
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> > File sandbox/linux/services/credentials.cc (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> > sandbox/linux/services/credentials.cc:73: // respecitively. It's ok to pass
> NULL
> > as one or both of the ids.
> > On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> > > respectively
> > 
> > Done.
> > 
> >
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> > sandbox/linux/services/credentials.cc:174: DVLOG(1) << "Uids or Gids
differ!";
> > On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> > > uids/gids (you were not using caps above).
> > 
> > Done.
> > 
> >
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> > File sandbox/linux/services/credentials.h (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> > sandbox/linux/services/credentials.h:55: // To be secure, it's very
important
> > that this API is not called with any
> > On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> > > .. very important for this API not to be called...
> > 
> > Done.
> > 
> >
>
https://chromiumcodereview.appspot.com/54643010/diff/90001/sandbox/linux/serv...
> > sandbox/linux/services/credentials.h:56: // directory file descriptor
present.
> > TODO(jln): integrate with
> > On 2013/11/05 00:44:51, Jorge Lucangeli Obes wrote:
> > > descriptors.
> > 
> > palmer@ says that singular is "more common". Keeping unless you object.
> 
> lgtm

Also, LOL at the linux_asan bot failing with the sys/capability.h error :-D

[jln (very slow on Chromium), 2013-11-05 18:56:21]

Committed patchset #7 manually as r233041 (presubmit successful).