Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 54643009: Disable Failing Imports related tests on official bots. (Closed)

Created:
7 years, 1 month ago by anantha
Modified:
7 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@moo
Visibility:
Public.

Description

Disabling following tests: ImportBookmarksFile ImportDefault ImportNothingAndShowNewTabPage BUG=314221

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M chrome/browser/first_run/first_run_browsertest.cc View 3 chunks +22 lines, -3 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/54643009/diff/1/chrome/browser/first_run/first_run_browsertest.cc File chrome/browser/first_run/first_run_browsertest.cc (right): https://codereview.chromium.org/54643009/diff/1/chrome/browser/first_run/first_run_browsertest.cc#newcode163 chrome/browser/first_run/first_run_browsertest.cc:163: // Fails on Mac and Linux official builds. See ...
7 years, 1 month ago (2013-11-01 22:49:04 UTC) #1
grt (UTC plus 2)
I would rather that we revert the change that broke the tests or fix the ...
7 years, 1 month ago (2013-11-03 01:47:02 UTC) #2
gab
https://codereview.chromium.org/54643009/diff/1/chrome/browser/first_run/first_run_browsertest.cc File chrome/browser/first_run/first_run_browsertest.cc (right): https://codereview.chromium.org/54643009/diff/1/chrome/browser/first_run/first_run_browsertest.cc#newcode163 chrome/browser/first_run/first_run_browsertest.cc:163: // Fails on Mac and Linux official builds. See ...
7 years, 1 month ago (2013-11-04 14:34:57 UTC) #3
gab
7 years, 1 month ago (2013-11-04 14:35:04 UTC) #4 
On 2013/11/03 01:47:02, grt wrote:
> I would rather that we revert the change that broke the tests or fix the
> waterfall builder instead of disabling the tests. Why are they passing on the
> main waterfall yet failing on the trunk builders?

+1

Powered by Google App Engine
This is Rietveld 408576698