Issue 54643008: Utilizing notifications.onShowSettings() event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54643008: Utilizing notifications.onShowSettings() event (Closed)

Created:
7 years, 1 month ago by vadimt

Modified:
7 years, 1 month ago

Reviewers:
robliao, skare_

CC:
chromium-reviews, arv+watch_chromium.org, govind1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Utilizing notifications.onShowSettings() event. BUG=164227 TEST=Click at (i) icon in NC Settings for GN, make sure that the help URL opens. R=robliao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232488

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -6 lines)			Patch
	M	chrome/browser/resources/google_now/background.js	View		5 chunks	+26 lines, -6 lines	1 comment	Download
	M	chrome/browser/resources/google_now/background_test_util.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robliao

lgtm https://codereview.chromium.org/54643008/diff/1/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/54643008/diff/1/chrome/browser/resources/google_now/background.js#newcode85 chrome/browser/resources/google_now/background.js:85: var SETTINGS_URL = 'https://support.google.com/chrome/?p=ib_google_now_welcome'; Watch out for merge ...

7 years, 1 month ago (2013-11-01 22:29:34 UTC) #2

vadimt

7 years, 1 month ago (2013-11-01 22:46:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r232488 (presubmit successful).

Expand Messages | Collapse Messages