Issue 54643006: Fix Java naming style

Issue 54643006: Fix Java naming style (Closed)

Created:
7 years, 1 month ago by abarth-chromium

Modified:
7 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Java naming style R=ben@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232427

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	mojo/services/native_viewport/android/mojo_viewport.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	mojo/services/native_viewport/android/src/org/chromium/mojo/MojoViewport.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Committed patchset #1 manually as r232427 (presubmit successful).

7 years, 1 month ago (2013-11-01 17:48:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/54643006/1

7 years, 1 month ago (2013-11-01 17:50:59 UTC) #4

commit-bot: I haz the power

7 years, 1 month ago (2013-11-01 17:51:01 UTC) #5

Message was sent while issue was closed.

Failed to apply patch for
mojo/services/native_viewport/android/mojo_viewport.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file mojo/services/native_viewport/android/mojo_viewport.cc
  Hunk #1 FAILED at 39.
  1 out of 1 hunk FAILED -- saving rejects to file
mojo/services/native_viewport/android/mojo_viewport.cc.rej

Patch:       mojo/services/native_viewport/android/mojo_viewport.cc
Index: mojo/services/native_viewport/android/mojo_viewport.cc
diff --git a/mojo/services/native_viewport/android/mojo_viewport.cc
b/mojo/services/native_viewport/android/mojo_viewport.cc
index
39615669d9ff2285b355031f6b706f2cfa2ead21..15f868f0f50010e895913392fbf3071a050adfb3
100644
--- a/mojo/services/native_viewport/android/mojo_viewport.cc
+++ b/mojo/services/native_viewport/android/mojo_viewport.cc
@@ -39,7 +39,7 @@ void MojoViewport::CreateForActivity(
     jobject activity,
     MojoViewportInit* init) {
   JNIEnv* env = base::android::AttachCurrentThread();
-  Java_MojoViewport_CreateForActivity(
+  Java_MojoViewport_createForActivity(
       env, activity, reinterpret_cast<jint>(init));
 }

Expand Messages | Collapse Messages