Issue 546373002: Revert of More System Dialog printing code disabled on Windows.

Issue 546373002: Revert of More System Dialog printing code disabled on Windows. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 3 months ago

Reviewers:
Lei Zhang, jschuh

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@522493002

Project:
chromium

Visibility:
Public.

Revert of More System Dialog printing code disabled on Windows. (patchset #3 id:40001 of https://codereview.chromium.org/517193003/) Reason for revert: Need also to check if !ENABLE_FULL_PRINTING Original issue's description: > More System Dialog printing code disabled on Windows. > > BUG=374321 > > Committed: https://chromium.googlesource.com/chromium/src/+/77daf4022522fd889f31fe8cb6abb33c45a54857 TBR=thestig@chromium.org,jschuh@chromium.org NOTREECHECKS=true NOTRY=true BUG=374321 Committed: https://crrev.com/73c2f4e82b1c516a01cb20d07ce444023323068d Cr-Commit-Position: refs/heads/master@{#293688}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -44 lines)			Patch
M	chrome/browser/printing/print_view_manager.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager_base.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager_base.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View	4 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_ui.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_ui.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/print_messages.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper.cc	View	5 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper_browsertest.cc	View	6 chunks	+4 lines, -9 lines	0 comments	Download

Total messages: 8 (4 generated)

Vitaly Buka (NO REVIEWS)

Created Revert of More System Dialog printing code disabled on Windows.

6 years, 3 months ago (2014-09-08 07:08:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/546373002/240001

6 years, 3 months ago (2014-09-08 07:35:46 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:240001) as a45418f0abc7bc3e30962b15250d82e47d7faad7

6 years, 3 months ago (2014-09-08 07:36:49 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:45:10 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/73c2f4e82b1c516a01cb20d07ce444023323068d
Cr-Commit-Position: refs/heads/master@{#293688}