Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerError.cpp

Issue 546353003: ServiceWorker: Change worker script fetch error code(1/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerError.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerError.cpp b/Source/modules/serviceworkers/ServiceWorkerError.cpp
index 320a9888996eca7e4cf5a1c2232126f2f1e0b1b7..dfd201d8b35ff1f3d9eacb4c05883c32c4a01426 100644
--- a/Source/modules/serviceworkers/ServiceWorkerError.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerError.cpp
@@ -47,7 +47,8 @@ PassRefPtrWillBeRawPtr<DOMException> ServiceWorkerError::take(ScriptPromiseResol
case WebServiceWorkerError::ErrorTypeAbort:
return DOMException::create(AbortError, "The Service Worker operation was aborted.");
case WebServiceWorkerError::ErrorTypeSecurity:
- return DOMException::create(SecurityError, "The Service Worker security policy prevented an action.");
+ // FIXME clean this once Chromium side change landed.
+ return DOMException::create(AbortError, "The Service Worker security policy prevented an action.");
nhiroki 2014/09/12 07:57:28 IIUC, you don't have to change this error type and
xiang 2014/09/16 05:47:41 Done.
case WebServiceWorkerError::ErrorTypeInstall:
// FIXME: Introduce new InstallError type to ExceptionCodes?
return DOMException::create(AbortError, "The Service Worker installation failed.");
@@ -55,6 +56,9 @@ PassRefPtrWillBeRawPtr<DOMException> ServiceWorkerError::take(ScriptPromiseResol
// Not currently returned as a promise rejection.
// FIXME: Introduce new ActivateError type to ExceptionCodes?
return DOMException::create(AbortError, "The Service Worker activation failed.");
+ case WebServiceWorkerError::ErrorTypeNetwork:
+ // FIXME clean this once Chromium side change landed.
+ return DOMException::create(AbortError, "The Service Worker failed by network.");
nhiroki 2014/09/12 07:57:28 ditto (you can pass "NetworkError" if disabling th
xiang 2014/09/16 05:47:41 Done.
case WebServiceWorkerError::ErrorTypeNotFound:
return DOMException::create(NotFoundError, "The specified Service Worker resource was not found.");
case WebServiceWorkerError::ErrorTypeUnknown:

Powered by Google App Engine
This is Rietveld 408576698