Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 546343004: Remove HasBeenShutdown check on iOS for the sign-in confirmation. (Closed)

Created:
6 years, 3 months ago by dconnelly
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org, Joao da Silva, lliabraa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove HasBeenShutdown check on iOS for the sign-in confirmation. BUG=405048 Committed: https://crrev.com/0782062b4a3faf3b78e03299f11c991e8937fd59 Cr-Commit-Position: refs/heads/master@{#293882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/ui/sync/profile_signin_confirmation_helper.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dconnelly
6 years, 3 months ago (2014-09-08 11:44:29 UTC) #2
Andrew T Wilson (Slow)
lgtm
6 years, 3 months ago (2014-09-08 17:18:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/546343004/1
6 years, 3 months ago (2014-09-08 17:48:38 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 22:45:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/546343004/1
6 years, 3 months ago (2014-09-09 06:14:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 75f8bcedcb510b9dc731bebd09da325f5a44fb30
6 years, 3 months ago (2014-09-09 07:12:01 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:33 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0782062b4a3faf3b78e03299f11c991e8937fd59
Cr-Commit-Position: refs/heads/master@{#293882}

Powered by Google App Engine
This is Rietveld 408576698