Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 546343002: Add fixed children of Google Drive in the directory tree only once. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add fixed children of Google Drive in the directory tree only once. BUG=410215 TEST=manually tested. Committed: https://crrev.com/4cd276bc81ad5f64d774b03c84fc53f24dca918a Cr-Commit-Position: refs/heads/master@{#293841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/directory_tree.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
fukino
@yoshiki - Could you take a look? Thank you!
6 years, 3 months ago (2014-09-08 05:33:45 UTC) #2
yoshiki
lgtm
6 years, 3 months ago (2014-09-08 08:16:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/546343002/1
6 years, 3 months ago (2014-09-08 08:17:21 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 10:21:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/546343002/1
6 years, 3 months ago (2014-09-08 11:04:14 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 13:04:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/546343002/1
6 years, 3 months ago (2014-09-09 00:28:22 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 084f24d8ab08a7198fd385da7123d19ab8c4d9ee
6 years, 3 months ago (2014-09-09 03:05:40 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:49:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cd276bc81ad5f64d774b03c84fc53f24dca918a
Cr-Commit-Position: refs/heads/master@{#293841}

Powered by Google App Engine
This is Rietveld 408576698