Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: sdk/lib/_internal/compiler/implementation/closure.dart

Issue 54623002: Fix bug in our SSA optimizations: by giving an empty type to a box, we were assuming that anything … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/closure.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/closure.dart (revision 29654)
+++ sdk/lib/_internal/compiler/implementation/closure.dart (working copy)
@@ -149,7 +149,7 @@
// more general solution.
class BoxElement extends ElementX {
BoxElement(String name, Element enclosingElement)
- : super(name, ElementKind.VARIABLE, enclosingElement);
+ : super(name, ElementKind.VARIABLE_LIST, enclosingElement);
DartType computeType(Compiler compiler) => compiler.types.dynamicType;
}
@@ -389,7 +389,7 @@
// A boxed element.
freeVariableMapping[fromElement] = updatedElement;
Element boxElement = updatedElement.enclosingElement;
- assert(boxElement.kind == ElementKind.VARIABLE);
+ assert(boxElement is BoxElement);
boxes.add(boxElement);
}
});
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698