Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 546163005: easy-unlock: Make policy fully override field trial. (Closed)

Created:
6 years, 3 months ago by xiyuan
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Tim Song, Alexei Svitkine (slow), Andrew T Wilson (Slow), Joao da Silva
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

easy-unlock: Make policy fully override field trial. This allows dogfooders to get Easy unlock on consumer devices (i.e. non-enrolled devices). BUG=395154 Committed: https://crrev.com/09098f7713f7cc8ea1faff9b6976301975675511 Cr-Commit-Position: refs/heads/master@{#294872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/browser/signin/easy_unlock_service.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xiyuan
Chrome side change needed to enable dogfooders on non-enrolled device. We lost the ability to ...
6 years, 3 months ago (2014-09-13 16:48:20 UTC) #2
tbarzic
lgtm
6 years, 3 months ago (2014-09-15 06:02:37 UTC) #3
Andrew T Wilson (Slow)
lgtm
6 years, 3 months ago (2014-09-15 08:13:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/546163005/1
6 years, 3 months ago (2014-09-15 18:25:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as cf2d0bb87b73bf0ed1dfdedc2d66c01fe9a76424
6 years, 3 months ago (2014-09-15 19:56:55 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 20:00:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09098f7713f7cc8ea1faff9b6976301975675511
Cr-Commit-Position: refs/heads/master@{#294872}

Powered by Google App Engine
This is Rietveld 408576698