Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py

Issue 546133003: Reformat webkitpy.layout_tests w/ format-webkitpy. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py b/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py
index 9b0f5d5dee3f1ecef25fcbbad2adffa6b8c80ce8..ebae16fec58f33753d2aaa2b6091499deeb5a594 100644
--- a/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py
+++ b/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py
@@ -49,19 +49,19 @@ _log = logging.getLogger(__name__)
# 'builder name' : {
# 'blinkRevision': [],
# 'tests': {
-# 'directory' { # Each path component is a dictionary.
+# 'directory' { # Each path component is a dictionary.
# 'testname.html': {
-# 'expected' : 'FAIL', # expectation name
-# 'results': [], # Run-length encoded result.
+# 'expected' : 'FAIL', # expectation name
+# 'results': [], # Run-length encoded result.
# 'times': [],
-# 'bugs': [], # bug urls
+# 'bugs': [], # bug urls
# }
# }
# }
# 'buildNumbers': [],
# 'secondsSinceEpoch': [],
# 'chromeRevision': [],
-# 'failure_map': { } # Map from letter code to expectation name.
+# 'failure_map': { } # Map from letter code to expectation name.
# },
class ResultsJSON(object):
TESTS_KEY = 'tests'
@@ -144,6 +144,7 @@ class BotTestExpectationsFactory(object):
return None
return BotTestExpectations(results_json)
+
class BotTestExpectations(object):
# FIXME: Get this from the json instead of hard-coding it.
RESULT_TYPES_TO_IGNORE = ['N', 'X', 'Y']
@@ -160,7 +161,7 @@ class BotTestExpectations(object):
line.filename = test_path
line.path = test_path # FIXME: Should this be normpath?
line.matching_tests = [test_path]
- line.bugs = bug_urls if bug_urls else ["Bug(gardener)"]
+ line.bugs = bug_urls if bug_urls else ['Bug(gardener)']
line.expectations = sorted(map(self.results_json.expectation_for_type, flaky_types))
line.specifiers = self.specifiers
return line

Powered by Google App Engine
This is Rietveld 408576698