Index: Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py |
diff --git a/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py b/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py |
index 23a31152b1ea6ff3f15aa2e9b51dfed72237ba71..c2c65834e1b936a46669c13f4e8bf62963a69162 100644 |
--- a/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py |
+++ b/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py |
@@ -37,6 +37,7 @@ _log = logging.getLogger(__name__) |
class DumpReaderMultipart(DumpReader): |
+ |
"""Base class for Linux and Android breakpad dump reader.""" |
def __init__(self, host, build_dir): |
@@ -65,7 +66,7 @@ class DumpReaderMultipart(DumpReader): |
self._generate_breakpad_symbols_if_necessary() |
f, temp_name = self._host.filesystem.open_binary_tempfile('dmp') |
- f.write("\r\n".join(dump['upload_file_minidump'])) |
+ f.write('\r\n'.join(dump['upload_file_minidump'])) |
f.close() |
cmd = [self._path_to_minidump_stackwalk(), temp_name, self._symbols_dir()] |
@@ -90,7 +91,7 @@ class DumpReaderMultipart(DumpReader): |
return None |
def _check_breakpad_tools_available(self): |
- if self._breakpad_tools_available != None: |
+ if self._breakpad_tools_available is not None: |
return self._breakpad_tools_available |
REQUIRED_BREAKPAD_TOOLS = [ |
@@ -114,10 +115,10 @@ class DumpReaderMultipart(DumpReader): |
return self._breakpad_tools_available |
def _path_to_minidump_stackwalk(self): |
- return self._host.filesystem.join(self._build_dir, "minidump_stackwalk") |
+ return self._host.filesystem.join(self._build_dir, 'minidump_stackwalk') |
def _path_to_generate_breakpad_symbols(self): |
- return self._webkit_finder.path_from_chromium_base("components", "crash", "tools", "generate_breakpad_symbols.py") |
+ return self._webkit_finder.path_from_chromium_base('components', 'crash', 'tools', 'generate_breakpad_symbols.py') |
def _symbols_dir(self): |
return self._host.filesystem.join(self._build_dir, 'content_shell.syms') |
@@ -127,7 +128,7 @@ class DumpReaderMultipart(DumpReader): |
return |
self._generated_symbols = True |
- _log.debug("Generating breakpad symbols") |
+ _log.debug('Generating breakpad symbols') |
for binary in self._binaries_to_symbolize(): |
full_path = self._host.filesystem.join(self._build_dir, binary) |
cmd = [ |
@@ -149,6 +150,7 @@ class DumpReaderMultipart(DumpReader): |
class DumpReaderLinux(DumpReaderMultipart): |
+ |
"""Linux breakpad dump reader.""" |
def _binaries_to_symbolize(self): |
@@ -159,6 +161,7 @@ class DumpReaderLinux(DumpReaderMultipart): |
class DumpReaderAndroid(DumpReaderMultipart): |
+ |
"""Android breakpad dump reader.""" |
def _binaries_to_symbolize(self): |