Ensure that an activity is activated when overview mode is exited

athena/wm/window_manager_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ATHENA_WM_WINDOW_MANAGER_IMPL_H_
 #define ATHENA_WM_WINDOW_MANAGER_IMPL_H_
 
 #include "athena/input/public/accelerator_manager.h"
 #include "athena/wm/public/window_manager.h"
 #include "athena/wm/title_drag_controller.h"
@@ skipping 33 matching lines @@
 
  private:
   friend class test::WindowManagerImplTestApi;
   friend class AthenaContainerLayoutManager;
 
   enum Command {
     CMD_TOGGLE_OVERVIEW,
     CMD_TOGGLE_SPLIT_VIEW,
   };
 
-  // Sets whether overview mode is active.
-  void SetInOverview(bool active);
+  // Enters overview mode.
+  void EnterOverview();
+
+  // Exits overview mode and activates |window|. |split_type| indicates whether
+  // the window should be part of split view and what position it should have in
+  // split view.
+  void ExitOverview(aura::Window* window, SplitType split_type);
+
+  // Exits overview mode. The window which is activated and whether split view
+  // is entered or exited is determinbed based on overview mode's current state.
+  void ExitOverview();

[sadrul, 2014/09/07 05:26:49]

The two functions do things differently enough that we should not use
overloading here.

 
   void ToggleSplitview();
 
   void InstallAccelerators();
 
   // WindowManager:
   virtual void AddObserver(WindowManagerObserver* observer) OVERRIDE;
   virtual void RemoveObserver(WindowManagerObserver* observer) OVERRIDE;
   virtual void ToggleSplitViewForTest() OVERRIDE;
 
   // WindowOverviewModeDelegate:
-  virtual void OnSelectWindow(aura::Window* window) OVERRIDE;
-  virtual void OnSplitViewMode(aura::Window* left,
-                               aura::Window* right) OVERRIDE;
+  virtual void OnSelectWindow(aura::Window* window,
+                              SplitType split_type) OVERRIDE;
 
   // aura::WindowObserver:
-  virtual void OnWindowAdded(aura::Window* new_window) OVERRIDE;
   virtual void OnWindowDestroying(aura::Window* window) OVERRIDE;
 
   // AcceleratorHandler:
   virtual bool IsCommandEnabled(int command_id) const OVERRIDE;
   virtual bool OnAcceleratorFired(int command_id,
                                   const ui::Accelerator& accelerator) OVERRIDE;
 
   // TitleDragControllerDelegate:
   virtual aura::Window* GetWindowBehind(aura::Window* window) OVERRIDE;
   virtual void OnTitleDragStarted(aura::Window* window) OVERRIDE;
   virtual void OnTitleDragCompleted(aura::Window* window) OVERRIDE;
   virtual void OnTitleDragCanceled(aura::Window* window) OVERRIDE;
 
   scoped_ptr<aura::Window> container_;
   scoped_ptr<WindowListProvider> window_list_provider_;
   scoped_ptr<WindowOverviewMode> overview_;
   scoped_ptr<BezelController> bezel_controller_;
   scoped_ptr<SplitViewController> split_view_controller_;
   scoped_ptr<wm::WMState> wm_state_;
   scoped_ptr<TitleDragController> title_drag_controller_;
   scoped_ptr<wm::ShadowController> shadow_controller_;
   ObserverList<WindowManagerObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowManagerImpl);
 };
 
 }  // namespace athena
 
 #endif  // ATHENA_WM_WINDOW_MANAGER_IMPL_H_