Embedded Extension Options: Open all external links in a new tab

chrome/browser/guest_view/extension_options/extension_options_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/guest_view/extension_options/extension_options_constants.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/extensions/api/extension_options_internal.h"
 #include "chrome/common/extensions/manifest_url_handler.h"
 #include "components/crx_file/id_util.h"
 #include "components/renderer_context_menu/context_menu_delegate.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_function_dispatcher.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/guest_view/guest_view_manager.h"
+#include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/feature_switch.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "extensions/strings/grit/extensions_strings.h"
 #include "ipc/ipc_message_macros.h"
 
 using content::WebContents;
 using namespace extensions::api;
 
@@ skipping 111 matching lines @@
 }
 
 bool ExtensionOptionsGuest::IsAutoSizeSupported() const {
   return true;
 }
 
 content::WebContents* ExtensionOptionsGuest::GetAssociatedWebContents() const {
   return web_contents();
 }
 
+content::WebContents* ExtensionOptionsGuest::OpenURLFromTab(
+    content::WebContents* source,
+    const content::OpenURLParams& params) {
+  Browser* browser =
+      chrome::FindBrowserWithWebContents(embedder_web_contents());
+
+  if ((!params.url.SchemeIs(extensions::kExtensionScheme) ||

[Fady Samuel, 2014/09/05 21:11:57]

Some comments describing what you're doing would be nice here.

[ericzeng, 2014/09/05 21:17:19]

Done.

+       params.url.host() != options_page_.host()) &&
+      params.disposition == CURRENT_TAB) {

[Fady Samuel, 2014/09/05 21:11:57]

Early exit preferred for readability.

[ericzeng, 2014/09/05 21:17:19]

How do I early exit for this condition? Wouldn't flipping the directionality be
just as verbose?

[Fady Samuel, 2014/09/05 21:18:01]

You're probably right...lgtm

+    return browser->OpenURL(
+        content::OpenURLParams(params.url,
+                               params.referrer,
+                               params.frame_tree_node_id,
+                               NEW_FOREGROUND_TAB,
+                               params.transition,
+                               params.is_renderer_initiated));
+  }
+  return browser->OpenURL(params);
+}
+
 void ExtensionOptionsGuest::CloseContents(content::WebContents* source) {
   DispatchEventToEmbedder(new extensions::GuestViewBase::Event(
       extension_options_internal::OnClose::kEventName,
       make_scoped_ptr(new base::DictionaryValue())));
 }
 
 bool ExtensionOptionsGuest::HandleContextMenu(
     const content::ContextMenuParams& params) {
   ContextMenuDelegate* menu_delegate =
       ContextMenuDelegate::FromWebContents(web_contents());
@@ skipping 63 matching lines @@
   attach_params()->GetInteger(extensionoptions::kAttributeMinHeight,
                               &min_height);
   attach_params()->GetInteger(extensionoptions::kAttributeMinWidth, &min_width);
 
   // Call SetAutoSize to apply all the appropriate validation and clipping of
   // values.
   SetAutoSize(auto_size_enabled,
               gfx::Size(min_width, min_height),
               gfx::Size(max_width, max_height));
 }