Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 546073002: Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. (patchset #5 id:80001 of https://codereview.chromium.org/520793002/) Reason for revert: Looks like it may have broken the layout tests. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31264 Original issue's description: > Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. > > Committed: https://chromium.googlesource.com/chromium/src/+/37ffe8f81510bbfb82b48640aa96fe7e51efc654 TBR=enne@chromium.org,senorblanco@chromium.org,sugoi@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7a459a6c506ce476e7baf3e4edfbc864308738fd Cr-Commit-Position: refs/heads/master@{#293568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -56 lines) Patch
M cc/output/gl_renderer.cc View 11 chunks +48 lines, -56 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
bsalomon
Created Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc.
6 years, 3 months ago (2014-09-05 19:52:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsalomon@google.com/546073002/1
6 years, 3 months ago (2014-09-05 19:53:27 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-05 19:53:28 UTC) #4
robertphillips
lgtm
6 years, 3 months ago (2014-09-05 19:55:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsalomon@google.com/546073002/1
6 years, 3 months ago (2014-09-05 19:56:26 UTC) #8
reveman
lgtm
6 years, 3 months ago (2014-09-05 19:57:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as cea33af6d0b2c2c1805ef016da5161fc0ed540a0
6 years, 3 months ago (2014-09-05 19:58:30 UTC) #11
arv (Not doing code reviews)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/547763003/ by arv@chromium.org. ...
6 years, 3 months ago (2014-09-05 22:47:32 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a459a6c506ce476e7baf3e4edfbc864308738fd
Cr-Commit-Position: refs/heads/master@{#293568}

Powered by Google App Engine
This is Rietveld 408576698