Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 546053003: [Mac] Fix the height of the email address field in the new avatar button. (Closed)

Created:
6 years, 3 months ago by noms (inactive)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix the height of the email address field in the new avatar button. BUG=410915 TEST=Start Chrome with --enable-new-avatar-menu. Sign in a profile. In the avatar menu, the descenders in the "@gmail.com" string should not be cut off. Committed: https://crrev.com/154af54fcedb39b59462532b17dc06f16aae0307 Cr-Commit-Position: refs/heads/master@{#293716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
noms (inactive)
6 years, 3 months ago (2014-09-05 19:54:08 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-05 19:57:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/546053003/1
6 years, 3 months ago (2014-09-05 20:12:11 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 03:05:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/546053003/1
6 years, 3 months ago (2014-09-08 14:00:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 98cdc889e74c9b0497f06cac65600748e29d506b
6 years, 3 months ago (2014-09-08 14:05:13 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/154af54fcedb39b59462532b17dc06f16aae0307
Cr-Commit-Position: refs/heads/master@{#293716}

Powered by Google App Engine
This is Rietveld 408576698