Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: tests/common/register_set.h

Issue 546043004: NonSFI mode: Make tests/common/register_set.h PIC-friendly. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: review Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/common/register_set.h
diff --git a/tests/common/register_set.h b/tests/common/register_set.h
index 5bb747d174b1c8fa1d02e322504c2c2d95fbf7ee..b85f2dd9eab61e4ba501ec444d4b3f3a7f80f55e 100644
--- a/tests/common/register_set.h
+++ b/tests/common/register_set.h
@@ -240,7 +240,7 @@ extern const uint8_t kX86FlagBits[5];
#def_func ":\n" \
/* Push most of "struct NaClSignalContext" in reverse order. */ \
"push $0\n" /* Leave space for flags */ \
- "push $" #def_func "\n" /* Fill out prog_ctr with known value */ \
+ "push $0\n" /* Leave space for prog_ctr */ \
"push %edi\n" \
"push %esi\n" \
"push %ebp\n" \
@@ -252,6 +252,12 @@ extern const uint8_t kX86FlagBits[5];
/* Save flags. */ \
SAVE_X86_FLAGS_INTO_REG("%eax") \
"movl %eax, 0x24(%esp)\n" \
+ /* Obtain def_func from GOT to fill prog_ctr with known value. */ \
+ "call 0f\n" \
+ "0: popl %eax\n" \
+ "1: addl $_GLOBAL_OFFSET_TABLE_ + (1b - 0b), %eax\n" \
+ "movl " #def_func "@GOT(%eax), %eax\n" \
+ "movl %eax, 0x20(%esp)\n" \
/* Adjust saved %esp value to account for preceding pushes. */ \
"addl $5 * 4, 0x10(%esp)\n" \
/* Save argument to callee_func() temporarily. */ \
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698