Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
546043003:
Remove an useless ifndef NDEBUG in video_capture_types.cc (Closed)
|
Created:
6 years, 3 months ago by Sébastien Marchand Modified:
6 years, 3 months ago CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionRemove an useless ifndef NDEBUG in video_capture_types.cc
Let's let the compiler do its job :). As mentionned in https://codereview.chromium.org/532533002/ this preprocessor precondition is useless as the linker will removed the unreferenced code anyway, and this break the PGO build.
TBR=magjed, tommi
NOTRY=true
Committed: https://crrev.com/a008610bbe1c26703f55a0b19a5a7103437f3931
Cr-Commit-Position: refs/heads/master@{#293667}
Patch Set 1 #
Messages
Total messages: 22 (10 generated)
PTAL, committing this as TBR as it break the PGO build.
The CQ bit was checked by sebmarchand@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/546043003/1
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded time limit waiting for builds to trigger.
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/546043003/1
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded time limit waiting for builds to trigger.
The CQ bit was checked by tommi@chromium.org
The CQ bit was unchecked by tommi@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/546043003/1
The CQ bit was checked by tommi@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
magjed@google.com changed reviewers: + magjed@google.com
lgtm
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/546043003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 94cda486db04238c6a93ea55ded57988131fe286
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a008610bbe1c26703f55a0b19a5a7103437f3931 Cr-Commit-Position: refs/heads/master@{#293667} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
