Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 546043002: Don't take a ref on GP in AutoEffectRestore. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Don't take a ref on GP in AutoEffectRestore. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/52e9d63f7110ac691609660342cdab32082a4235

Patch Set 1 #

Patch Set 2 : fix comment. #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M include/gpu/GrGpuResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrProgramElement.h View 1 2 4 chunks +9 lines, -1 line 0 comments Download
M src/gpu/GrDrawState.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrProgramElement.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
Previous change was still causing refs on GPs after they we're converted to pending execution. ...
6 years, 3 months ago (2014-09-05 18:58:17 UTC) #2
robertphillips
lgtm + 1 nit https://codereview.chromium.org/546043002/diff/20001/include/gpu/GrProgramElement.h File include/gpu/GrProgramElement.h (right): https://codereview.chromium.org/546043002/diff/20001/include/gpu/GrProgramElement.h#newcode86 include/gpu/GrProgramElement.h:86: Line this up ?
6 years, 3 months ago (2014-09-05 19:11:29 UTC) #3
bsalomon
https://codereview.chromium.org/546043002/diff/20001/include/gpu/GrProgramElement.h File include/gpu/GrProgramElement.h (right): https://codereview.chromium.org/546043002/diff/20001/include/gpu/GrProgramElement.h#newcode86 include/gpu/GrProgramElement.h:86: On 2014/09/05 19:11:29, robertphillips wrote: > Line this up ...
6 years, 3 months ago (2014-09-05 19:12:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/546043002/40001
6 years, 3 months ago (2014-09-05 19:13:49 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 19:23:17 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 52e9d63f7110ac691609660342cdab32082a4235

Powered by Google App Engine
This is Rietveld 408576698