Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 546033002: Embedded Extension Options: Change header border from shadow to line (Closed)

Created:
6 years, 3 months ago by ericzeng
Modified:
6 years, 3 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, not at google - send to devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Embedded Extension Options: Change header border from shadow to line Change the divider between the popup header and the options page content from a box-shadow to a bottom-border, as suggested in UI review. BUG=411995 Committed: https://crrev.com/5e3eccc1745636ced4f71f1a83907c9c11c1f108 Cr-Commit-Position: refs/heads/master@{#293810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/extensions/extension_options_overlay.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ericzeng
PTAL
6 years, 3 months ago (2014-09-05 18:51:36 UTC) #2
Finnur
LGTM
6 years, 3 months ago (2014-09-08 15:24:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/546033002/1
6 years, 3 months ago (2014-09-08 18:48:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 10150edcfceb980eac76688acc45bc23639d5f01
6 years, 3 months ago (2014-09-08 23:21:25 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:48:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e3eccc1745636ced4f71f1a83907c9c11c1f108
Cr-Commit-Position: refs/heads/master@{#293810}

Powered by Google App Engine
This is Rietveld 408576698