Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 54603003: Update colorama from upstream to 5a3100113a3a. (Closed)

Created:
7 years, 1 month ago by M-A Ruel
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Update colorama from upstream to 5a3100113a3a. This fixes license headers. Interestingly, the pylint workaround at r133705 doesn't seem to be necessary anymore. R=stip@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=232152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -101 lines) Patch
M third_party/colorama/LICENSE.txt View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/colorama/README.chromium View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/colorama/README.txt View 11 chunks +66 lines, -26 lines 0 comments Download
M third_party/colorama/__init__.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/colorama/ansi.py View 4 chunks +11 lines, -13 lines 0 comments Download
M third_party/colorama/ansitowin32.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/colorama/initialise.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/colorama/win32.py View 3 chunks +73 lines, -48 lines 0 comments Download
M third_party/colorama/winterm.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
If that sticks, I'll do the same for swarming.client, removing the need of the skip ...
7 years, 1 month ago (2013-10-31 15:02:10 UTC) #1
ghost stip (do not use)
lgtm is this change for the licensing, or are there technical changes as well?
7 years, 1 month ago (2013-10-31 17:23:45 UTC) #2
M-A Ruel
On 2013/10/31 17:23:45, stip wrote: > lgtm > > is this change for the licensing, ...
7 years, 1 month ago (2013-10-31 17:25:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/54603003/1
7 years, 1 month ago (2013-10-31 17:28:36 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 17:30:57 UTC) #5
Message was sent while issue was closed.
Change committed as 232152

Powered by Google App Engine
This is Rietveld 408576698