Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 545983006: Fix incorrect Rec601 YUV conversion matrix coefficient. (Closed)

Created:
6 years, 3 months ago by rileya (GONE FROM CHROMIUM)
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix incorrect Rec601 YUV conversion matrix coefficient. For future reference, the rec 601 matrix can be defined by the concatenation of these 2 matrices: [1.164 0.0 1.596 0.0] [1.164 -0.391 -0.813 0.0] [1.164 2.018 0.0 0.0] [1.164 0.0 0.0 1.0] See: http://www.fourcc.org/fccyvrgb.php and [1.0 0.0 0.0 -0.0625] [0.0 1.0 0.0 -0.5 ] [0.0 0.0 1.0 -0.5 ] [0.0 0.0 0.0 1.0 ] Which transforms Y by -0.0625 (-16/256) and U and V by -0.5 (-128/256) each. Giving us the final matrix: [1.164 0.0 1.596 -0.87075] [1.164 -0.391 -0.813 0.52925] [1.164 2.018 0.0 -1.08175] [0.0 0.0 0.0 1.0 ] Which produces our output [R,G,B,A], when multiplied with an input [Y,U,V,A]. Committed: https://skia.googlesource.com/skia/+/223ba624b70ed5732688e3a8a63a423a9f9b02ad

Patch Set 1 #

Patch Set 2 : Add a couple digits to another coeff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rileya (GONE FROM CHROMIUM)
Whoops, good thing I forgot to remove the yuv_to_rgb_effect tests from the ignored gm list... ...
6 years, 3 months ago (2014-09-16 04:23:12 UTC) #2
bsalomon
lgtm
6 years, 3 months ago (2014-09-16 13:15:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/545983006/20001
6 years, 3 months ago (2014-09-16 13:16:17 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 13:23:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 223ba624b70ed5732688e3a8a63a423a9f9b02ad

Powered by Google App Engine
This is Rietveld 408576698