 Chromium Code Reviews
 Chromium Code Reviews Issue 545973003:
  Update network error template to new design  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 545973003:
  Update network error template to new design  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/renderer/resources/neterror.js | 
| diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js | 
| index 14117c4804925bbe1dbda8ebf79adc392e7eba92..3aed27d105f26e76896879f30959cf7b72b16a19 100644 | 
| --- a/chrome/renderer/resources/neterror.js | 
| +++ b/chrome/renderer/resources/neterror.js | 
| @@ -126,5 +126,18 @@ function setButtonLayout() { | 
| staleLoadButton.style.display == 'none') { | 
| detailsButton.classList.add('singular'); | 
| } | 
| + | 
| + // Hide the details button if there are no details to show. | 
| + if (templateData && templateData.summary && !templateData.summary.msg) { | 
| + document.getElementById('details-button').classList.add('hidden'); | 
| 
arv (Not doing code reviews)
2014/09/15 17:35:43
How about just using .hidden instead of class hidd
 
edwardjung
2014/09/16 13:14:30
Done. Thanks for the tip.
 | 
| + document.getElementById('help-box-outer').style.display = 'block'; | 
| + } | 
| } | 
| -document.addEventListener('DOMContentLoaded', setButtonLayout); | 
| + | 
| +document.addEventListener('DOMContentLoaded', function() { | 
| + setButtonLayout(); | 
| + if (document.querySelector('.icon-offline')) { | 
| + document.body.classList.add('offline'); | 
| + new Runner('.interstitial-wrapper'); | 
| + } | 
| + }); |