Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4960)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/resources/neterror.html

Issue 545973003: Update network error template to new design (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove debug code from JS file. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/renderer/resources/neterror.css ('K') | « chrome/renderer/resources/neterror.css ('k') | chrome/renderer/resources/neterror.js » ('j') | chrome/renderer/resources/neterror.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/neterror.html
diff --git a/chrome/renderer/resources/neterror.html b/chrome/renderer/resources/neterror.html
index ecfe903d9475824d5b808ea297160a85fb31f66b..3ead620f1102e4ae381c0978d0a6d755dab68621 100644
--- a/chrome/renderer/resources/neterror.html
+++ b/chrome/renderer/resources/neterror.html
@@ -1,75 +1,74 @@
<!DOCTYPE html>
-<html i18n-values="dir:textdirection">
+<html i18n-values="dir:textdirection;.style.fontSize:fontsize">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0,
maximum-scale=1.0, user-scalable=no">
<title i18n-content="title"></title>
+ <link rel="stylesheet" href="../../browser/resources/security_warnings/interstitial_v2.css">
<link rel="stylesheet" href="neterror.css">
<script src="neterror.js"></script>
+ <script src="offline.js"></script>
</head>
-<body id="t">
- <div id="main-frame-error">
- <div id="box">
- <div id="content-top">
- <h1>
- <div>
- <img class="icon"
- jseval="updateIconClass(this.classList, iconClass)">
- </div>
- <span i18n-content="heading"></span>
- </h1>
- <div id="buttons">
- <div id="control-buttons">
- <button id="reload-button"
- class="blue-button text-button"
- onclick="trackClick(this.trackingId);
- reloadButtonClick(this.url);"
- jsselect="reloadButton"
- jsvalues=".url:reloadUrl; .trackingId:reloadTrackingId"
- jscontent="msg"></button>
- <button id="stale-load-button"
- class="blue-button text-button"
- onclick="loadStaleButtonClick()"
- jsselect="staleLoadButton"
- jscontent="msg" jsvalues="title:title"></button>
- </div>
- <button id="details-button" class="text-button"
- onclick="detailsButtonClick(); toggleHelpBox()"
- jsdisplay="details" jscontent="details"
- jsvalues=".detailsText:details; .hideDetailsText:hideDetails;">
- </a>
+<body id="t" i18n-values=".style.fontFamily:fontfamily">
+ <div id="main-frame-error" class="interstitial-wrapper">
+ <img class="icon"
+ jseval="updateIconClass(this.classList, iconClass)">
+ <div id="main-message">
+ <h1>
+ <span i18n-content="heading"></span>
arv (Not doing code reviews) 2014/09/15 17:35:43 Skip this span and move the i18n-content to the h1
edwardjung 2014/09/16 13:14:30 Done.
+ </h1>
+ <p i18n-values=".innerHTML:primaryParagraph"></p>
+ <div id="buttons" class="nav-wrapper">
+ <div id="control-buttons">
+ <button id="reload-button"
+ class="blue-button text-button"
+ onclick="trackClick(this.trackingId);
+ reloadButtonClick(this.url);"
+ jsselect="reloadButton"
+ jsvalues=".url:reloadUrl; .trackingId:reloadTrackingId"
+ jscontent="msg"></button>
+ <button id="stale-load-button"
+ class="blue-button text-button"
+ onclick="loadStaleButtonClick()"
+ jsselect="staleLoadButton"
+ jscontent="msg" jsvalues="title:title"></button>
</div>
+ <a href="#" id="details-button" class="text-button"
+ onclick="detailsButtonClick(); toggleHelpBox()"
+ jsdisplay="details" jscontent="details"
+ jsvalues=".detailsText:details; .hideDetailsText:hideDetails;">
+ </a>
</div>
- <!-- Outer and inner divs are needed both for margins and sizing. -->
- <div id="help-box-outer" class="hidden">
- <div id="help-box-inner">
- <div jsselect="summary">
- <span jsvalues=".innerHTML:msg"></span>
- </div>
- <div class="suggestions" jsselect="suggestions">
- <div class="suggestion-header" jsvalues=".innerHTML:header"></div>
- <div class="suggestion-body" jsvalues=".innerHTML:body"></div>
- </div>
- <button class="text-button" id="diagnose-button"
- onclick="diagnoseErrors()" jscontent="diagnose"
- jsdisplay="diagnose"></button>
- <div id="diagnose-frame" class="hidden"></div>
- <form class="suggestions" jsdisplay="searchUrl"
- jsvalues=".url:searchUrl; .trackingId:searchTrackingId"
- onsubmit="trackClick(this.trackingId); return search(this.url);">
- <div class="suggestion-header" jscontent="searchHeader"></div>
- <div id="search-container">
- <input type="text" name="q" id="search-box"
- jsvalues=".value:searchTerms" />
- <button type="submit" id="search-button" class="blue-button"
- jsvalues="aria-label:searchHeader">
- <img id="search-image">
- </button>
- </div>
- </form>
- <div class="error-code" jscontent="errorCode"></div>
+ </div>
+ <!-- Outer and inner divs are needed both for margins and sizing. -->
+ <div id="help-box-outer" class="hidden">
+ <div id="details">
+ <div jsselect="summary">
+ <span jsvalues=".innerHTML:msg"></span>
</div>
+ <div class="suggestions" jsselect="suggestions">
+ <div class="suggestion-header" jsvalues=".innerHTML:header"></div>
+ <div class="suggestion-body" jsvalues=".innerHTML:body"></div>
+ </div>
+ <button class="text-button" id="diagnose-button"
+ onclick="diagnoseErrors()" jscontent="diagnose"
+ jsdisplay="diagnose"></button>
+ <div id="diagnose-frame" class="hidden"></div>
+ <form class="suggestions" jsdisplay="searchUrl"
+ jsvalues=".url:searchUrl; .trackingId:searchTrackingId"
+ onsubmit="trackClick(this.trackingId); return search(this.url);">
+ <div class="suggestion-header" jscontent="searchHeader"></div>
+ <div id="search-container">
+ <input type="text" name="q" id="search-box"
+ jsvalues=".value:searchTerms" />
+ <button type="submit" id="search-button" class="blue-button"
+ jsvalues="aria-label:searchHeader">
+ <img id="search-image">
+ </button>
+ </div>
+ </form>
+ <div class="error-code" jscontent="errorCode"></div>
</div>
</div>
</div>
@@ -80,5 +79,30 @@
jsvalues=".title:errorDetails">
<div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div>
</div>
+
+ <div id="offline-resources">
arv (Not doing code reviews) 2014/09/15 17:35:43 Can these be moved to js so you don't have to map
edwardjung 2014/09/16 13:14:30 As the page will be offline I can't access the res
arv (Not doing code reviews) 2014/09/16 14:20:20 I was thinking doing new Audio(src) and new Image(
+ <div id="offline-resources-1x">
+ <img id="1x-obstacle-large" src="default_100_percent/offline/100-obstacle-large-sprite.png">
+ <img id="1x-obstacle-small" src="default_100_percent/offline/100-obstacle-small-sprite.png">
+ <img id="1x-cloud" src="default_100_percent/offline/100-cloud.png">
+ <img id="1x-text" src="default_100_percent/offline/100-text-sprite.png">
+ <img id="1x-horizon" src="default_100_percent/offline/100-horizon.png">
+ <img id="1x-trex" src="default_100_percent/offline/100-offline-trex.png">
+ <img id="1x-restart" src="default_100_percent/offline/100-restart.png">
+ </div>
+ <div id="offline-resources-2x">
+ <img id="2x-obstacle-large" src="default_200_percent/offline/200-obstacle-large-sprite.png">
+ <img id="2x-obstacle-small" src="default_200_percent/offline/200-obstacle-small-sprite.png">
+ <img id="2x-cloud" src="default_200_percent/offline/200-cloud.png">
+ <img id="2x-text" src="default_200_percent/offline/200-text-sprite.png">
+ <img id="2x-horizon" src="default_200_percent/offline/200-horizon.png">
+ <img id="2x-trex" src="default_200_percent/offline/200-offline-trex.png">
+ <img id="2x-restart" src="default_200_percent/offline/200-restart.png">
+ </div>
+
+ <audio id="offline-sound-press" src="sounds/button-press.mp3"></audio>
+ <audio id="offline-sound-hit" src="sounds/hit.mp3"></audio>
+ <audio id="offline-sound-reached" src="sounds/score-reached.mp3"></audio>
+ </div>
</body>
</html>
« chrome/renderer/resources/neterror.css ('K') | « chrome/renderer/resources/neterror.css ('k') | chrome/renderer/resources/neterror.js » ('j') | chrome/renderer/resources/neterror.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698