Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: extensions/browser/api/capture_web_contents_function.h

Issue 545973002: Cleaning up capture_web_contents_function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/browser/api/capture_web_contents_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/capture_web_contents_function.h
diff --git a/extensions/browser/api/capture_web_contents_function.h b/extensions/browser/api/capture_web_contents_function.h
index cad6e5abd952fbdde0a96db9de6509f14dfb6e9e..59d3cbe5af6e2ac6133e0c2ec91f29a74ac90019 100644
--- a/extensions/browser/api/capture_web_contents_function.h
+++ b/extensions/browser/api/capture_web_contents_function.h
@@ -5,6 +5,7 @@
#ifndef EXTENSIONS_BROWSER_API_CAPTURE_WEB_CONTENTS_FUNCTION_H_
#define EXTENSIONS_BROWSER_API_CAPTURE_WEB_CONTENTS_FUNCTION_H_
+#include "extensions/browser/extension_function.h"
#include "extensions/common/api/extension_types.h"
class SkBitmap;
@@ -17,10 +18,7 @@ namespace extensions {
// Base class for capturing visibile area of a WebContents.
// This is used by both webview.captureVisibleRegion and tabs.captureVisibleTab.
-// The template parameter T should be either AsyncExtensionFunction or
-// ChromeAsyncExtensionFunction (in the cases the chrome Profile is required)
-template <typename T>
-class CaptureWebContentsFunction : public T {
+class CaptureWebContentsFunction : public AsyncExtensionFunction {
public:
CaptureWebContentsFunction() {}
@@ -41,9 +39,6 @@ class CaptureWebContentsFunction : public T {
};
virtual void OnCaptureFailure(FailureReason reason) = 0;
- // ValidationFailure override to match RunAsync().
- static bool ValidationFailure(CaptureWebContentsFunction* function);
-
private:
typedef core_api::extension_types::ImageDetails ImageDetails;
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/browser/api/capture_web_contents_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698