Fix the NavController unittest.

Fix unittest.

BUG=407376
TEST=no visible change

Committed: https://crrev.com/29fb2a0a83d70f694fe0f10031cc353539b341dc
Cr-Commit-Position: refs/heads/master@{#293978}

[Avi (use Gerrit), 2014-09-09 16:44:54]

avi@chromium.org changed reviewers:
+ creis@chromium.org, nasko@chromium.org

[Avi (use Gerrit), 2014-09-09 16:44:55]

Nasko: IPC, Charlie: all of it.

Two things are going on here. First, the unittest is testing the browser side of
things without fully implementing the renderer side, so now that we have an
explicit IPC to set the page id, that's not matching. So put it back to -1.
(This actually reverts yesterday's change in that file.)

Second, we drop "page id" from the "did navigate" parms. Yesterday's patch
introduced the IPC to do the update, and no one actually uses this copy of the
page id (!) so let's kill it.

[Avi (use Gerrit), 2014-09-09 17:19:16]

Pause; something's wrong here.

[Avi (use Gerrit), 2014-09-09 17:34:49]

avi@chromium.org changed reviewers:
- nasko@chromium.org

[Avi (use Gerrit), 2014-09-09 17:34:50]

OK, this makes no sense. I remove something that's unused and a million tests
break. Huh?

For now let's fix that one test. Nasko, this is for Charlie alone now.

[jam, 2014-09-09 18:17:27]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2014-09-09 18:17:27]

lgtm

[Avi (use Gerrit), 2014-09-09 18:17:43]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-09-09 18:21:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi@chromium.org/545963003/40001

[commit-bot: I haz the power, 2014-09-09 18:59:49]

Committed patchset #3 (id:40001) as 6d4519558b39482cdaa5a68a53ae1adca9a2a55a

[Charlie Reis, 2014-09-10 00:52:00]

The unittest part LGTM too.

I'm confused how the removal of params.page_id compiled, since we're referencing
it in places like NavigationControllerImpl::ClassifyNavigation.  What am I
missing?

[Avi (use Gerrit), 2014-09-10 03:36:27]

On 2014/09/10 00:52:00, Charlie Reis wrote:
> The unittest part LGTM too.
> 
> I'm confused how the removal of params.page_id compiled, since we're
referencing
> it in places like NavigationControllerImpl::ClassifyNavigation.  What am I
> missing?

I was being clever, and thought it was defined in frame_messages.h. It's not!
It's in content/public/common/frame_navigate_params.h/cc.

FYI, it's not ready yet, but have a peek at
https://codereview.chromium.org/556703004/. Once the whole page id thing
stabilizes, that's next.

[commit-bot: I haz the power, 2014-09-10 03:54:37]

Patchset 3 (id:??) landed as
https://crrev.com/29fb2a0a83d70f694fe0f10031cc353539b341dc
Cr-Commit-Position: refs/heads/master@{#293978}