Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 545953002: Let guests on ChromeOS still search. (Closed)

Created:
6 years, 3 months ago by Mike Lerman
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Let guests on ChromeOS still search. BUG=411178 Committed: https://crrev.com/e6ee2ef28a255c107732baead3a7dc762fd05740 Cr-Commit-Position: refs/heads/master@{#293965}

Patch Set 1 #

Patch Set 2 : Refactor to a helper method #

Total comments: 2

Patch Set 3 : One line function #

Total comments: 1

Patch Set 4 : Fewer parens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/resources/options/search_page.js View 1 2 3 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Mike Lerman
Hi Evan, Can you take a look at this, please? Thanks! This CL (https://codereview.chromium.org/517633002/) didn't ...
6 years, 3 months ago (2014-09-05 16:06:14 UTC) #2
Evan Stade
can you create a ShouldEnableSearch function?
6 years, 3 months ago (2014-09-05 17:41:07 UTC) #3
Mike Lerman
On 2014/09/05 17:41:07, Evan Stade wrote: > can you create a ShouldEnableSearch function? Done.
6 years, 3 months ago (2014-09-05 20:20:11 UTC) #4
Evan Stade
https://codereview.chromium.org/545953002/diff/20001/chrome/browser/resources/options/search_page.js File chrome/browser/resources/options/search_page.js (right): https://codereview.chromium.org/545953002/diff/20001/chrome/browser/resources/options/search_page.js#newcode24 chrome/browser/resources/options/search_page.js:24: if (loadTimeData.getBoolean('profileIsGuest') && !cr.isChromeOS) return (expression);
6 years, 3 months ago (2014-09-05 21:02:33 UTC) #5
Mike Lerman
https://codereview.chromium.org/545953002/diff/20001/chrome/browser/resources/options/search_page.js File chrome/browser/resources/options/search_page.js (right): https://codereview.chromium.org/545953002/diff/20001/chrome/browser/resources/options/search_page.js#newcode24 chrome/browser/resources/options/search_page.js:24: if (loadTimeData.getBoolean('profileIsGuest') && !cr.isChromeOS) On 2014/09/05 21:02:33, Evan Stade ...
6 years, 3 months ago (2014-09-08 13:51:14 UTC) #6
Evan Stade
lgtm https://codereview.chromium.org/545953002/diff/40001/chrome/browser/resources/options/search_page.js File chrome/browser/resources/options/search_page.js (right): https://codereview.chromium.org/545953002/diff/40001/chrome/browser/resources/options/search_page.js#newcode24 chrome/browser/resources/options/search_page.js:24: return (!loadTimeData.getBoolean('profileIsGuest') || cr.isChromeOS); sorry I put parentheses ...
6 years, 3 months ago (2014-09-08 18:42:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/545953002/60001
6 years, 3 months ago (2014-09-09 15:33:12 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 29868647f81bd9f5d31dcc4d5e8ff15b2a3ff9df
6 years, 3 months ago (2014-09-09 18:01:14 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:13 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e6ee2ef28a255c107732baead3a7dc762fd05740
Cr-Commit-Position: refs/heads/master@{#293965}

Powered by Google App Engine
This is Rietveld 408576698