Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameFeedback.java

Issue 545943003: Include additional information into RenameFeedback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/doc/api.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameFeedback.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameFeedback.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameFeedback.java
index 0f34eacdcc4e5c612a0a929e69efa1dddddfbbbd..918ca2dc0470fac9f3ee295d1283942834711e4d 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameFeedback.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameFeedback.java
@@ -52,11 +52,24 @@ public class RenameFeedback extends RefactoringFeedback {
private final int length;
/**
+ * The human-readable description of the kind of element being renamed (such as “class” or
+ * “function type alias”).
+ */
+ private final String elementKindName;
+
+ /**
+ * The old name of the element before the refactoring.
+ */
+ private final String oldName;
+
+ /**
* Constructor for {@link RenameFeedback}.
*/
- public RenameFeedback(int offset, int length) {
+ public RenameFeedback(int offset, int length, String elementKindName, String oldName) {
this.offset = offset;
this.length = length;
+ this.elementKindName = elementKindName;
+ this.oldName = oldName;
}
@Override
@@ -65,7 +78,9 @@ public class RenameFeedback extends RefactoringFeedback {
RenameFeedback other = (RenameFeedback) obj;
return
other.offset == offset &&
- other.length == length;
+ other.length == length &&
+ ObjectUtilities.equals(other.elementKindName, elementKindName) &&
+ ObjectUtilities.equals(other.oldName, oldName);
}
return false;
}
@@ -73,7 +88,9 @@ public class RenameFeedback extends RefactoringFeedback {
public static RenameFeedback fromJson(JsonObject jsonObject) {
int offset = jsonObject.get("offset").getAsInt();
int length = jsonObject.get("length").getAsInt();
- return new RenameFeedback(offset, length);
+ String elementKindName = jsonObject.get("elementKindName").getAsString();
+ String oldName = jsonObject.get("oldName").getAsString();
+ return new RenameFeedback(offset, length, elementKindName, oldName);
}
public static List<RenameFeedback> fromJsonArray(JsonArray jsonArray) {
@@ -89,6 +106,14 @@ public class RenameFeedback extends RefactoringFeedback {
}
/**
+ * The human-readable description of the kind of element being renamed (such as “class” or
+ * “function type alias”).
+ */
+ public String getElementKindName() {
+ return elementKindName;
+ }
+
+ /**
* The length of the name selected to be renamed.
*/
public int getLength() {
@@ -102,11 +127,20 @@ public class RenameFeedback extends RefactoringFeedback {
return offset;
}
+ /**
+ * The old name of the element before the refactoring.
+ */
+ public String getOldName() {
+ return oldName;
+ }
+
@Override
public int hashCode() {
HashCodeBuilder builder = new HashCodeBuilder();
builder.append(offset);
builder.append(length);
+ builder.append(elementKindName);
+ builder.append(oldName);
return builder.toHashCode();
}
@@ -114,6 +148,8 @@ public class RenameFeedback extends RefactoringFeedback {
JsonObject jsonObject = new JsonObject();
jsonObject.addProperty("offset", offset);
jsonObject.addProperty("length", length);
+ jsonObject.addProperty("elementKindName", elementKindName);
+ jsonObject.addProperty("oldName", oldName);
return jsonObject;
}
@@ -124,7 +160,11 @@ public class RenameFeedback extends RefactoringFeedback {
builder.append("offset=");
builder.append(offset + ", ");
builder.append("length=");
- builder.append(length);
+ builder.append(length + ", ");
+ builder.append("elementKindName=");
+ builder.append(elementKindName + ", ");
+ builder.append("oldName=");
+ builder.append(oldName);
builder.append("]");
return builder.toString();
}
« no previous file with comments | « no previous file | pkg/analysis_server/doc/api.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698