Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/core/html/MediaProvider.h

Issue 545933002: Implement HTMLMediaElement::srcObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
sof 2014/09/18 07:33:17 Use a short copyright here also.
perkj_chrome 2014/09/18 14:47:09 Done.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer 11 * notice, this list of conditions and the following disclaimer
12 * in the documentation and/or other materials provided with the 12 * in the documentation and/or other materials provided with the
13 * distribution. 13 * distribution.
14 * 3. Neither the name of Google Inc. nor the names of its contributors 14 * 3. Neither the name of Google Inc. nor the names of its contributors
15 * may be used to endorse or promote products derived from this 15 * may be used to endorse or promote products derived from this
16 * software without specific prior written permission. 16 * software without specific prior written permission.
17 * 17 *
18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #ifndef MediaProvider_h
32 #include "core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h" 32 #define MediaProvider_h
33 33
34 #include "core/dom/custom/CustomElementMicrotaskImportStep.h" 34 #include "platform/heap/Handle.h"
35 #include "wtf/Functional.h"
35 36
36 namespace blink { 37 namespace blink {
37 38
38 void CustomElementAsyncImportMicrotaskQueue::enqueue(PassOwnPtrWillBeRawPtr<Cust omElementMicrotaskStep> step) 39 class EventTarget;
39 { 40 class MediaProvider;
40 m_queue.append(step); 41 class ScriptValue;
41 }
42 42
43 void CustomElementAsyncImportMicrotaskQueue::doDispatch() 43 class MediaProvider : public WillBeGarbageCollectedMixin {
sof 2014/09/18 07:33:17 Do you need to derive from WillBeGarbageCollectedM
perkj_chrome 2014/09/18 14:47:09 I do right? Since HTMLMediaElement must be able to
44 { 44 public:
45 WillBeHeapVector<OwnPtrWillBeMember<CustomElementMicrotaskStep> > remaining; 45 // Converter must be a static function and is used for converting between a ScriptValue and a MediaProvider instance.
46 // If the ScriptValue can not be converted to a MediaProvider, the function must return null.
47 typedef Function<MediaProvider*(const ScriptValue&)> Converter;
48 static MediaProvider* convert(const ScriptValue&);
46 49
47 for (unsigned i = 0; i < m_queue.size(); ++i) { 50 MediaProvider(const String& interfaceName, const Converter&);
48 if (CustomElementMicrotaskStep::Processing == m_queue[i]->process()) 51 virtual ~MediaProvider() { };
sof 2014/09/18 07:33:17 nit: remove ";"
perkj_chrome 2014/09/18 14:47:09 Done.
49 remaining.append(m_queue[i].release());
50 }
51 52
52 m_queue.swap(remaining); 53 virtual EventTarget* eventTarget() = 0;
53 } 54 virtual const String& getObjectUrl() = 0;
55 };
54 56
55 } // namespace blink 57 } // namespace blink
58
59 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698