Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 545923002: Mixed Content: Start measuring the impact of blocking private IPs. (Closed)

Created:
6 years, 3 months ago by Mike West
Modified:
6 years, 3 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Mixed Content: Start measuring the impact of blocking private IPs. Before we know whether or not we can implement [1], let's find out how hard it will hit the portions of the web for which we can gather UMA data. BUG=378566 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
WDYT, Jochen? -mike
6 years, 3 months ago (2014-09-05 14:01:19 UTC) #2
jochen (gone - plz use gerrit)
lgtm just to double check, isReservedIPAddress() won't resolve the hostname, right?
6 years, 3 months ago (2014-09-08 12:15:20 UTC) #3
Mike West
On 2014/09/08 12:15:20, jochen wrote: > lgtm > > just to double check, isReservedIPAddress() won't ...
6 years, 3 months ago (2014-09-08 12:36:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/545923002/1
6 years, 3 months ago (2014-09-08 12:37:51 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 13:42:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181557

Powered by Google App Engine
This is Rietveld 408576698