include/utils/SkDeferredCanvas.h - Issue 545813002: Picture Recording: fix the performance bottleneck in SkDeferredCanvas::isFullFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/utils/SkDeferredCanvas.h

Issue 545813002: Picture Recording: fix the performance bottleneck in SkDeferredCanvas::isFullFrame (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: use interface in SkDeferredCanvas Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/utils/SkDeferredCanvas.h

diff --git a/include/utils/SkDeferredCanvas.h b/include/utils/SkDeferredCanvas.h

index 907cb91575043b1cfba2f16c1b27e4d6982c0516..de95bc7494906f5057bb3abefe17d0586a563c6d 100644

--- a/include/utils/SkDeferredCanvas.h

+++ b/include/utils/SkDeferredCanvas.h

@@ -243,12 +243,13 @@ private:

void recordedDrawCommand();

SkCanvas* drawingCanvas() const;

SkCanvas* immediateCanvas() const;

- bool isFullFrame(const SkRect*, const SkPaint*) const;

+ bool isFullFrame(const SkRect*, const SkPaint*);

void validate() const;

void init();

size_t fBitmapSizeThreshold;

bool fDeferredDrawing;

+ SkISize canvasSize;

reed1 2014/09/05 13:18:33 nit: fCanvasSize

yunchao 2014/09/09 08:58:00 Done.

friend class SkDeferredCanvasTester; // for unit testing

typedef SkCanvas INHERITED;

« no previous file with comments | « no previous file | src/utils/SkDeferredCanvas.cpp » ('j') | src/utils/SkDeferredCanvas.cpp » ('J')