Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 545773002: Change vsmul method from vDSP_ to VectorMatch. (Closed)

Created:
6 years, 3 months ago by KhNo
Modified:
6 years, 3 months ago
Reviewers:
Raymond Toy
CC:
blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Change vsmul method from vDSP_ to VectorMatch. Inside of VectorMatch::vsmul is calling vDSP_vsmul when MACOS macro is enabled. FFTFrameMac is used both method VectorMatch::vsmul and vDSP_vsmul. It needs to change to VectorMatch for code maintenance. BUG=411128 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/audio/mac/FFTFrameMac.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
KhNo
PTAL
6 years, 3 months ago (2014-09-05 02:56:15 UTC) #2
Raymond Toy
LGTM Thanks for splitting this out from the FFTFrame CL.
6 years, 3 months ago (2014-09-05 05:04:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/545773002/1
6 years, 3 months ago (2014-09-05 05:07:58 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 06:18:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181444

Powered by Google App Engine
This is Rietveld 408576698