Calculate stage stats in GrOptDrawState

src/gpu/gl/GrGLProgramDesc.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "gl/builders/GrGLProgramBuilder.h"
 #include "GrGLProgramDesc.h"
 #include "GrBackendEffectFactory.h"
 #include "GrEffect.h"
 #include "GrGpuGL.h"
 #include "GrOptDrawState.h"
 
 #include "SkChecksum.h"
 
-bool GrGLProgramDesc::GetEffectKeyAndUpdateStats(const GrEffectStage& stage,
-                                                 const GrGLCaps& caps,
-                                                 bool useExplicitLocalCoords,
-                                                 GrEffectKeyBuilder* b,
-                                                 uint16_t* effectKeySize,
-                                                 bool* setTrueIfReadsDst,
-                                                 bool* setTrueIfReadsPos,
-                                                 bool* setTrueIfRequiresVertexShader) {
+bool GrGLProgramDesc::GetEffectKey(const GrEffectStage& stage, const GrGLCaps& caps,
+                                   bool useExplicitLocalCoords, GrEffectKeyBuilder* b,
+                                   uint16_t* effectKeySize) {
     const GrBackendEffectFactory& factory = stage.getEffect()->getFactory();
     const GrEffect& effect = *stage.getEffect();
-    if (effect.willReadDstColor()) {
-        *setTrueIfReadsDst = true;
-    }
-    if (effect.willReadFragmentPosition()) {
-        *setTrueIfReadsPos = true;
-    }
-    if (effect.requiresVertexShader()) {
-        *setTrueIfRequiresVertexShader = true;
-    }
     factory.getGLEffectKey(effect, caps, b);
     size_t size = b->size();
     if (size > SK_MaxU16) {
         *effectKeySize = 0; // suppresses a warning.
         return false;
     }
     *effectKeySize = SkToU16(size);
     if (!GrGLProgramEffects::GenEffectMetaKey(stage,
                                               useExplicitLocalCoords,
                                               caps,
@@ skipping 23 matching lines @@
     // descriptor will not affect program generation (because of the attribute
     // bindings in use or other descriptor field settings) it should be set
     // to a canonical value to avoid duplicate programs with different keys.
 
     bool requiresColorAttrib = optState.hasColorVertexAttribute();
     bool requiresCoverageAttrib = optState.hasCoverageVertexAttribute();
     // we only need the local coords if we're actually going to generate effect code
     bool requiresLocalCoordAttrib = optState.numTotalStages() > 0 &&
                                     optState.hasLocalCoordAttribute();
 
-    bool readsDst = false;
-    bool readFragPosition = false;
-
-    // Provide option for shader programs without vertex shader only when drawing paths.
-    bool requiresVertexShader = !GrGpu::IsPathRenderingDrawType(drawType);
-
     int numStages = optState.numTotalStages();
 
     GR_STATIC_ASSERT(0 == kEffectKeyOffsetsAndLengthOffset % sizeof(uint32_t));
     // Make room for everything up to and including the array of offsets to effect keys.
     desc->fKey.reset();
     desc->fKey.push_back_n(kEffectKeyOffsetsAndLengthOffset + 2 * sizeof(uint16_t) * numStages);
 
     int offsetAndSizeIndex = 0;
     bool effectKeySuccess = true;
 
     KeyHeader* header = desc->header();
     // make sure any padding in the header is zeroed.
     memset(desc->header(), 0, kHeaderSize);
 
     // We can only have one effect which touches the vertex shader
     if (optState.hasGeometryProcessor()) {
         uint16_t* offsetAndSize =
                 reinterpret_cast<uint16_t*>(desc->fKey.begin() + kEffectKeyOffsetsAndLengthOffset +
                                             offsetAndSizeIndex * 2 * sizeof(uint16_t));
 
             GrEffectKeyBuilder b(&desc->fKey);
             uint16_t effectKeySize;
             uint32_t effectOffset = desc->fKey.count();
-            effectKeySuccess |= GetEffectKeyAndUpdateStats(
-                                    *optState.getGeometryProcessor(), gpu->glCaps(),
-                                    requiresLocalCoordAttrib, &b,
-                                    &effectKeySize, &readsDst,
-                                    &readFragPosition, &requiresVertexShader);
+            effectKeySuccess |= GetEffectKey(*optState.getGeometryProcessor(), gpu->glCaps(),
+                                             requiresLocalCoordAttrib, &b, &effectKeySize);
             effectKeySuccess |= (effectOffset <= SK_MaxU16);
 
             offsetAndSize[0] = SkToU16(effectOffset);
             offsetAndSize[1] = effectKeySize;
             ++offsetAndSizeIndex;
             *geometryProcessor = optState.getGeometryProcessor();
-            SkASSERT(requiresVertexShader);
             header->fHasGeometryProcessor = true;
     }
 
     for (int s = 0; s < optState.numColorStages(); ++s) {
         uint16_t* offsetAndSize =
             reinterpret_cast<uint16_t*>(desc->fKey.begin() + kEffectKeyOffsetsAndLengthOffset +
                                         offsetAndSizeIndex * 2 * sizeof(uint16_t));
 
-        bool effectRequiresVertexShader = false;
         GrEffectKeyBuilder b(&desc->fKey);
         uint16_t effectKeySize;
         uint32_t effectOffset = desc->fKey.count();
-        effectKeySuccess |= GetEffectKeyAndUpdateStats(
-            optState.getColorStage(s), gpu->glCaps(),
-            requiresLocalCoordAttrib, &b,
-            &effectKeySize, &readsDst,
-            &readFragPosition, &effectRequiresVertexShader);
+        effectKeySuccess |= GetEffectKey(optState.getColorStage(s), gpu->glCaps(),
+                                         requiresLocalCoordAttrib, &b, &effectKeySize);
         effectKeySuccess |= (effectOffset <= SK_MaxU16);
 
         offsetAndSize[0] = SkToU16(effectOffset);
         offsetAndSize[1] = effectKeySize;
         ++offsetAndSizeIndex;
-        SkASSERT(!effectRequiresVertexShader);
     }
 
     for (int s = 0; s < optState.numCoverageStages(); ++s) {
         uint16_t* offsetAndSize =
             reinterpret_cast<uint16_t*>(desc->fKey.begin() + kEffectKeyOffsetsAndLengthOffset +
                                         offsetAndSizeIndex * 2 * sizeof(uint16_t));
 
-        bool effectRequiresVertexShader = false;
         GrEffectKeyBuilder b(&desc->fKey);
         uint16_t effectKeySize;
         uint32_t effectOffset = desc->fKey.count();
-        effectKeySuccess |= GetEffectKeyAndUpdateStats(
-            optState.getCoverageStage(s), gpu->glCaps(),
-            requiresLocalCoordAttrib, &b,
-            &effectKeySize, &readsDst,
-            &readFragPosition, &effectRequiresVertexShader);
+        effectKeySuccess |= GetEffectKey(optState.getCoverageStage(s), gpu->glCaps(),
+                                         requiresLocalCoordAttrib, &b, &effectKeySize);
         effectKeySuccess |= (effectOffset <= SK_MaxU16);
 
         offsetAndSize[0] = SkToU16(effectOffset);
         offsetAndSize[1] = effectKeySize;
         ++offsetAndSizeIndex;
-        SkASSERT(!effectRequiresVertexShader);
     }
 
     if (!effectKeySuccess) {
         desc->fKey.reset();
         return false;
     }
 
     // Because header is a pointer into the dynamic array, we can't push any new data into the key
     // below here.
 
-    header->fRequiresVertexShader = requiresVertexShader || requiresLocalCoordAttrib;
+    // We will only use vertex shader if we have a geometry processor and we should not have a

[bsalomon, 2014/09/16 21:54:20]

use->require ?

[egdaniel, 2014/09/17 15:00:14]

Done.

+    // geometry processor if we are doing path rendering.
+    // TODO: Once we have a default GeometryProcessor on all programs not using path rendering,
+    // we can remove the !GrGpu::IsPathRenderingDrawType(drawType) in setting header
+    SkASSERT(!GrGpu::IsPathRenderingDrawType(drawType) || !optState.requiresVertexShader());

[bsalomon, 2014/09/16 21:54:20]

can requriesLocalCoordAttrib be part of optState.requiresVertexShader()'s
result? Also wouldn't vertex color or coverage also cause us to require a VS?

Maybe in the future we say a path draw causes us to ignore vertex attribs and
GPs. The ODS could just drop them when computing an ODS from a DS for a path
draw. That might also mean a different, smaller desc for the shader since we
don't require a VS.

[egdaniel, 2014/09/17 15:00:14]

Moved the checking of requires local coord attrib to ODS
requiresVS now is just checking if fVACount > 1

+    header->fRequiresVertexShader = optState.requiresVertexShader() ||
+                                    requiresLocalCoordAttrib ||
+                                    !GrGpu::IsPathRenderingDrawType(drawType);
     header->fEmitsPointSize = GrGpu::kDrawPoints_DrawType == drawType;
 
     // Currently the experimental GS will only work with triangle prims (and it doesn't do anything
     // other than pass through values from the VS to the FS anyway).
 #if GR_GL_EXPERIMENTAL_GS
 #if 0
     header->fExperimentalGS = gpu->caps().geometryShaderSupport();
 #else
     header->fExperimentalGS = false;
 #endif
@@ skipping 13 matching lines @@
 
     if (covIsSolidWhite || !inputCoverageIsUsed) {
         header->fCoverageInput = kAllOnes_ColorInput;
     } else if (defaultToUniformInputs && !requiresCoverageAttrib) {
         header->fCoverageInput = kUniform_ColorInput;
     } else {
         header->fCoverageInput = kAttribute_ColorInput;
         header->fRequiresVertexShader = true;
     }
 
-    if (readsDst) {
+    if (optState.readsDst()) {
         SkASSERT(dstCopy || gpu->caps()->dstReadInShaderSupport());
         const GrTexture* dstCopyTexture = NULL;
         if (dstCopy) {
             dstCopyTexture = dstCopy->texture();
         }
         header->fDstReadKey = GrGLFragmentShaderBuilder::KeyForDstRead(dstCopyTexture,
                 gpu->glCaps());
         SkASSERT(0 != header->fDstReadKey);
     } else {
         header->fDstReadKey = 0;
     }
 
-    if (readFragPosition) {
+    if (optState.readsFragPosition()) {
         header->fFragPosKey = GrGLFragmentShaderBuilder::KeyForFragmentPosition(
                 optState.getRenderTarget(), gpu->glCaps());
     } else {
         header->fFragPosKey = 0;
     }
 
     // Record attribute indices
     header->fPositionAttributeIndex = optState.positionAttributeIndex();
     header->fLocalCoordAttributeIndex = optState.localCoordAttributeIndex();
 
@@ skipping 37 matching lines @@
                 separateCoverageFromColor = true;
             } else if (kSA_GrBlendCoeff == dstCoeff) {
                 // SA dst coeff becomes 1-(1-SA)*coverage when dst is partially covered.
                 header->fCoverageOutput = kSecondaryCoverageISA_CoverageOutput;
                 separateCoverageFromColor = true;
             } else if (kSC_GrBlendCoeff == dstCoeff) {
                 // SA dst coeff becomes 1-(1-SA)*coverage when dst is partially covered.
                 header->fCoverageOutput = kSecondaryCoverageISC_CoverageOutput;
                 separateCoverageFromColor = true;
             }
-        } else if (readsDst &&
+        } else if (optState.readsDst() &&
                    kOne_GrBlendCoeff == srcCoeff &&
                    kZero_GrBlendCoeff == dstCoeff) {
             header->fCoverageOutput = kCombineWithDst_CoverageOutput;
             separateCoverageFromColor = true;
         }
     }
 
     for (int s = 0; s < optState.numColorStages(); ++s) {
         colorStages->push_back(&optState.getColorStage(s));
     }
@@ skipping 23 matching lines @@
     *checksum = 0;
     *checksum = SkChecksum::Compute(reinterpret_cast<uint32_t*>(fKey.begin()), keyLength);
 }
 
 GrGLProgramDesc& GrGLProgramDesc::operator= (const GrGLProgramDesc& other) {
     size_t keyLength = other.keyLength();
     fKey.reset(keyLength);
     memcpy(fKey.begin(), other.fKey.begin(), keyLength);
     return *this;
 }