Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 545653002: Make RenderFrameProxy a WebRemoteFrameClient (Closed)

Created:
6 years, 3 months ago by Nate Chapin
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit), nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make RenderFrameProxy a WebRemoteFrameClient Implement postMessageEvent(), which is nearly identical to RenderFrameImpl::willCheckAndDispatchMessageEvent(). The most notable difference is the void return value, as remote frames know that the MessageEvent must be delievered cross-process. This is step 2 of 3 in getting WebRemoteFrameClient up and running. BUG=411066 Committed: https://crrev.com/4dad341e3f332a8cda581a2115bcceb0d2c52db6 Cr-Commit-Position: refs/heads/master@{#294009}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address avi's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
M content/renderer/render_frame_proxy.h View 1 3 chunks +9 lines, -2 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Nate Chapin
This depends on blink rolling past http://src.chromium.org/viewvc/blink?view=revision&revision=181569
6 years, 3 months ago (2014-09-08 17:08:41 UTC) #2
nasko
LGTM
6 years, 3 months ago (2014-09-08 17:15:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/545653002/1
6 years, 3 months ago (2014-09-08 22:10:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9528)
6 years, 3 months ago (2014-09-09 02:25:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/545653002/1
6 years, 3 months ago (2014-09-09 17:13:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9682)
6 years, 3 months ago (2014-09-09 17:23:37 UTC) #11
Avi (use Gerrit)
lgtm Stampity Stamp with formatting nits. https://codereview.chromium.org/545653002/diff/1/content/renderer/render_frame_proxy.cc File content/renderer/render_frame_proxy.cc (right): https://codereview.chromium.org/545653002/diff/1/content/renderer/render_frame_proxy.cc#newcode248 content/renderer/render_frame_proxy.cc:248: Why two \n\n? ...
6 years, 3 months ago (2014-09-09 18:25:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/545653002/20001
6 years, 3 months ago (2014-09-09 19:00:07 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7f54b12052225f4ef4af6129f8cb209649c9f142
6 years, 3 months ago (2014-09-09 21:13:15 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:39 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4dad341e3f332a8cda581a2115bcceb0d2c52db6
Cr-Commit-Position: refs/heads/master@{#294009}

Powered by Google App Engine
This is Rietveld 408576698