Don't preresolve DNS if a fixed proxy configuration is in place.

chrome/browser/net/predictor_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <time.h>
 
 #include <algorithm>
 #include <sstream>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/timer/timer.h"
 #include "base/values.h"
 #include "chrome/browser/net/predictor.h"
 #include "chrome/browser/net/spdyproxy/proxy_advisor.h"
 #include "chrome/browser/net/url_info.h"
 #include "chrome/common/net/predictor_common.h"
 #include "content/public/test/test_browser_thread.h"
 #include "net/base/address_list.h"
+#include "net/base/load_flags.h"
+#include "net/base/net_errors.h"
 #include "net/base/winsock_init.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/http/transport_security_state.h"
+#include "net/proxy/proxy_config_service_fixed.h"
+#include "net/proxy/proxy_service.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::Time;
 using base::TimeDelta;
 using content::BrowserThread;
 
 namespace chrome_browser_net {
 
 class WaitForResolutionHelper;
@@ skipping 823 matching lines @@
   testing_master.PreconnectUrl(goog, goog, UrlInfo::OMNIBOX_MOTIVATED, 2);
 
   EXPECT_EQ(advisor->would_proxy_count_, 0);
   EXPECT_EQ(advisor->advise_count_, 1);
 
   testing_master.Shutdown();
 }
 
 #endif  // defined(OS_ANDROID) || defined(OS_IOS)
 
+net::ProxyService::PacRequest* FAKE_PAC_REQUEST_ADDRESS =
+    reinterpret_cast<net::ProxyService::PacRequest*>(123454321);
+
+class TestProxyService : public net::ProxyService {
+ public:
+  TestProxyService(int resolve_code, const net::ProxyInfo& proxy_info)
+      : ProxyService(new net::ProxyConfigServiceFixed(net::ProxyConfig()),
+            NULL, NULL),
+        resolve_code_(resolve_code),
+        proxy_info_(proxy_info),
+        pac_request_is_outstanding_(false) {
+  }
+
+  virtual ~TestProxyService() {
+    EXPECT_FALSE(pac_request_is_outstanding_);
+  }
+
+  virtual int ResolveProxy(const GURL& url,
+                           int load_flags,
+                           net::ProxyInfo* result,
+                           const net::CompletionCallback& callback,
+                           PacRequest** pac_request,
+                           net::NetworkDelegate* network_delegate,
+                           const net::BoundNetLog& net_log) OVERRIDE {
+    *pac_request = FAKE_PAC_REQUEST_ADDRESS;
+    if (resolve_code_ == net::LOAD_NORMAL) {
+      *result = proxy_info_;
+      callback.Run(resolve_code_);
+    } else {
+      pac_request_is_outstanding_ = true;
+    }
+
+    return resolve_code_;
+  }
+
+  virtual void CancelPacRequest(PacRequest* req) OVERRIDE {
+    DCHECK_EQ(FAKE_PAC_REQUEST_ADDRESS, req);
+    DCHECK(pac_request_is_outstanding_);
+    pac_request_is_outstanding_ = false;
+  }
+
+  int resolve_code_;
+  const net::ProxyInfo& proxy_info_;
+  bool pac_request_is_outstanding_;
+};
+
+TEST_F(PredictorTest, NoProxyService) {
+  // Don't actually try to resolve names.
+  Predictor::set_max_parallel_resolves(0);
+
+  Predictor testing_master(true, true);
+
+  GURL goog("http://www.google.com:80");
+  testing_master.Resolve(goog, UrlInfo::OMNIBOX_MOTIVATED);
+  EXPECT_FALSE(testing_master.work_queue_.IsEmpty());
+
+  testing_master.Shutdown();
+}
+
+TEST_F(PredictorTest, ProxyDefinitelyEnabled) {
+  // Don't actually try to resolve names.
+  Predictor::set_max_parallel_resolves(0);
+
+  Predictor testing_master(true, true);
+  net::ProxyInfo info;
+  info.UseNamedProxy("socks://localhost:12345");
+  testing_master.proxy_service_ = new TestProxyService(net::LOAD_NORMAL, info);
+
+  GURL goog("http://www.google.com:80");
+  testing_master.Resolve(goog, UrlInfo::OMNIBOX_MOTIVATED);
+  EXPECT_TRUE(testing_master.work_queue_.IsEmpty());
+
+  delete testing_master.proxy_service_;
+  testing_master.Shutdown();
+}
+
+TEST_F(PredictorTest, ProxyDefinitelyNotEnabled) {
+  // Don't actually try to resolve names.
+  Predictor::set_max_parallel_resolves(0);
+
+  Predictor testing_master(true, true);
+  net::ProxyInfo info;
+  info.UseDirect();
+  testing_master.proxy_service_ = new TestProxyService(net::LOAD_NORMAL, info);
+
+  GURL goog("http://www.google.com:80");
+  testing_master.Resolve(goog, UrlInfo::OMNIBOX_MOTIVATED);
+  EXPECT_FALSE(testing_master.work_queue_.IsEmpty());
+
+  delete testing_master.proxy_service_;
+  testing_master.Shutdown();
+}
+
+TEST_F(PredictorTest, ProxyMaybeEnabled) {
+  // Don't actually try to resolve names.
+  Predictor::set_max_parallel_resolves(0);
+
+  Predictor testing_master(true, true);
+  net::ProxyInfo info;
+  testing_master.proxy_service_ =
+      new TestProxyService(net::ERR_IO_PENDING, info);
+
+  GURL goog("http://www.google.com:80");
+  testing_master.Resolve(goog, UrlInfo::OMNIBOX_MOTIVATED);
+  EXPECT_FALSE(testing_master.work_queue_.IsEmpty());
+
+  delete testing_master.proxy_service_;
+  testing_master.Shutdown();
+}
+
 }  // namespace chrome_browser_net