Implement all SkCanvas overrides that SkPictureRecord does.

Implement all SkCanvas overrides that SkPictureRecord does.

Primarily this is for isDrawingToLayer().  drawData() and onNewSurface() are
for completeness.

BUG=409138
Committed: https://skia.googlesource.com/skia/+/29dfaa80f5776904f42b72b387a99e75f8dc5f5f

[mtklein, 2014-09-04 20:27:08]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-09-04 20:27:15]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/545613002/1

[commit-bot: I haz the power, 2014-09-04 20:27:16]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-09-05 02:27 UTC

[mtklein, 2014-09-04 20:30:13]

mtklein@google.com changed reviewers:
+ robertphillips@google.com

[mtklein, 2014-09-04 20:38:27]

mtklein@google.com changed reviewers:
+ reed@google.com

[mtklein, 2014-09-04 20:38:27]

+reed

[reed1, 2014-09-04 20:53:04]

https://codereview.chromium.org/545613002/diff/1/src/core/SkRecorder.h
File src/core/SkRecorder.h (right):

https://codereview.chromium.org/545613002/diff/1/src/core/SkRecorder.h#newcod...
src/core/SkRecorder.h:136: SkTDArray<bool> fSaveIsSaveLayer;
absurd nit: SkBool8 may be smaller than bool

https://codereview.chromium.org/545613002/diff/1/tests/RecorderTest.cpp
File tests/RecorderTest.cpp (right):

https://codereview.chromium.org/545613002/diff/1/tests/RecorderTest.cpp#newco...
tests/RecorderTest.cpp:73: DEF_TEST(Recorder_DrawData, r) {
for a future CL: perhaps this test could/should be written in a generic picture
test, where we record and then play into a custom canvas.

[mtklein, 2014-09-04 20:57:16]

https://codereview.chromium.org/545613002/diff/1/src/core/SkRecorder.h
File src/core/SkRecorder.h (right):

https://codereview.chromium.org/545613002/diff/1/src/core/SkRecorder.h#newcod...
src/core/SkRecorder.h:136: SkTDArray<bool> fSaveIsSaveLayer;
On 2014/09/04 20:53:04, reed1 wrote:
> absurd nit: SkBool8 may be smaller than bool

Done.

https://codereview.chromium.org/545613002/diff/1/tests/RecorderTest.cpp
File tests/RecorderTest.cpp (right):

https://codereview.chromium.org/545613002/diff/1/tests/RecorderTest.cpp#newco...
tests/RecorderTest.cpp:73: DEF_TEST(Recorder_DrawData, r) {
On 2014/09/04 20:53:04, reed1 wrote:
> for a future CL: perhaps this test could/should be written in a generic
picture
> test, where we record and then play into a custom canvas.

Acknowledged.

[mtklein, 2014-09-04 20:58:11]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-09-04 20:58:12]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/545613002/20001

[commit-bot: I haz the power, 2014-09-04 20:58:13]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-09-05 02:58 UTC

[reed1, 2014-09-04 21:04:57]

lgtm

[mtklein, 2014-09-04 21:06:25]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-09-04 21:06:26]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-09-04 21:06:33]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/545613002/20001

[commit-bot: I haz the power, 2014-09-04 21:12:50]

Committed patchset #2 (id:20001) as 29dfaa80f5776904f42b72b387a99e75f8dc5f5f