Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: content/browser/service_worker/service_worker_cache_unittest.cc

Issue 545533002: Move ServiceWorkerCache backend creation to a lazy init function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_pointers_keys
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_cache_storage.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_cache_unittest.cc
diff --git a/content/browser/service_worker/service_worker_cache_unittest.cc b/content/browser/service_worker/service_worker_cache_unittest.cc
index 5aa521bb85271e082f22ee038cb65c50acb65f98..4480dba9acf3c6b1d14a8273131a925bfd9573ae 100644
--- a/content/browser/service_worker/service_worker_cache_unittest.cc
+++ b/content/browser/service_worker/service_worker_cache_unittest.cc
@@ -76,7 +76,6 @@ class ServiceWorkerCacheTest : public testing::Test {
url_request_context,
blob_storage_context->context()->AsWeakPtr());
}
- CreateBackend();
}
virtual void TearDown() OVERRIDE {
@@ -123,15 +122,6 @@ class ServiceWorkerCacheTest : public testing::Test {
GURL("http://example.com/no_body.html"), 200, "OK", headers, "");
}
- void CreateBackend() {
- scoped_ptr<base::RunLoop> loop(new base::RunLoop());
- cache_->CreateBackend(base::Bind(&ServiceWorkerCacheTest::ErrorTypeCallback,
- base::Unretained(this),
- base::Unretained(loop.get())));
- loop->Run();
- EXPECT_EQ(ServiceWorkerCache::ErrorTypeOK, callback_error_);
- }
-
scoped_ptr<ServiceWorkerFetchRequest> CopyFetchRequest(
const ServiceWorkerFetchRequest& request) {
return make_scoped_ptr(new ServiceWorkerFetchRequest(request.url,
@@ -293,7 +283,7 @@ TEST_P(ServiceWorkerCacheTestP, PutBody) {
EXPECT_TRUE(Put(body_request_, body_response_));
}
-TEST_P(ServiceWorkerCacheTestP, PutBodyDropBlobRef) {
+TEST_F(ServiceWorkerCacheTest, PutBodyDropBlobRef) {
scoped_ptr<base::RunLoop> loop(new base::RunLoop());
cache_->Put(CopyFetchRequest(body_request_),
CopyFetchResponse(body_response_),
« no previous file with comments | « content/browser/service_worker/service_worker_cache_storage.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698